exportfs_monitor in exportfs does not support wildcard exports about resource-agents

[dmuhamedagic]

Can you please send me your email address so that I can credit you for the patch. Or clone and submit a pull request. But please add the local statement:

--- a/heartbeat/exportfs
+++ b/heartbeat/exportfs
@@ -181,9 +181,11 @@ END

exportfs_monitor ()
{

•   local clientspec_re
  # "grep -z" matches across newlines, which is necessary as
  # exportfs output wraps lines for long export directory names
  

•   exportfs | grep -zqs "${OCF_RESKEY_directory}[[:space:]]*${OCF_RESKEY_clientspec}"
  

•   clientspec_re=`echo ${OCF_RESKEY_clientspec} | sed 's/*/[*]/'`
  

•   exportfs | grep -zqs "${OCF_RESKEY_directory}[[:space:]]*${clientspec_re}"
  

  #Adapt grep status code to OCF return code
  case $? in

[acqant]

Sorry I don't submit patches much. I forked and submitted a pull request.

On Fri, Dec 9, 2011 at 12:13 AM, Dejan Muhamedagic <
[email protected]

wrote:

Can you please send me your email address so that I can credit you for the
patch. Or clone and submit a pull request. But please add the local
statement:

--- a/heartbeat/exportfs
+++ b/heartbeat/exportfs
@@ -181,9 +181,11 @@ END

exportfs_monitor ()
{

•   local clientspec_re
  

  "grep -z" matches across newlines, which is necessary as

  exportfs output wraps lines for long export directory names

•   exportfs | grep -zqs
  

  "${OCF_RESKEY_directory}[[:space:]]*${OCF_RESKEY_clientspec}"

•   clientspec_re=`echo ${OCF_RESKEY_clientspec} | sed 's/*/[*]/'`
  

•   exportfs | grep -zqs
  

  "${OCF_RESKEY_directory}[[:space:]]*${clientspec_re}"

  #Adapt grep status code to OCF return code
  case $? in

---

Reply to this email directly or view it on GitHub:

#39 (comment)

[dmuhamedagic]

This has been fixed here:

commit 5b0bf96
Author: Lars Ellenberg [email protected]
Date: Tue Jan 31 23:20:26 2012 +0100

Medium: fix exportfs monitor action for special characters and common suffixes

Many thanks for the report and code!