`findif` doesn't properly detect interfaces about resource-agents

[tserong]

I hit the same problem with a 3.x kernel on SUSE, and I can confirm that your patch fixes it. I would suggest a small tweak as follows, so it doesn't modify *best_netmask until after the procfile is successfully opened, and removes the nested 'if' (although, really, this is probably mostly academic...)

diff --git a/tools/findif.c b/tools/findif.c
index 72452f7..b911ae2 100644
--- a/tools/findif.c
+++ b/tools/findif.c
@@ -198,6 +198,7 @@ SearchUsingProcRoute (char *address, struct in_addr *in
        ,   PROCROUTE);
        rc = OCF_ERR_GENERIC; goto out;
    }
+   *best_netmask = 0;
    while (fgets(buf, sizeof(buf), routefd) != NULL) {
        if (sscanf(buf, "%[^\t]\t%lx%lx%lx%lx%lx%lx%lx"
        ,   interface, &dest, &gw, &flags, &refcnt, &use
@@ -208,7 +209,7 @@ SearchUsingProcRoute (char *address, struct in_addr *in
            rc = OCF_ERR_GENERIC; goto out;
        }
        if ( (in->s_addr&mask) == (in_addr_t)(dest&mask)
-       &&  metric < best_metric) {
+       &&  metric <= best_metric && mask >= *best_netmask) {
            best_metric = metric;
            *best_netmask = mask;
            strncpy(best_if, interface, best_iflen);

[dmuhamedagic]

Good work! Many thanks. Tim, can you please apply your version of the patch.

[tserong]

Done: de3074c

[b-a-t]

Just want to thank you, guys, for the quick resolution of the problem and commit! Nice team work :)