GithubHelp home page GithubHelp logo

Comments (9)

schildbach avatar schildbach commented on August 29, 2024 1

I think we should accept signatures with an expired key in the Dockerfile. Builds are supposed to succeed even in years, a time-bomb is inappropriate here imho.

I'm happy to provide a PR if you agree.

from docker-tor-hidden-service.

schildbach avatar schildbach commented on August 29, 2024

I'm not entirely sure, but it seems that the key FE43009C4607B1FB which this build relies on expired on 2019-09-21.

from docker-tor-hidden-service.

cmehay avatar cmehay commented on August 29, 2024

Yes this is the issue.

As the current stable tag was signed with this expired key, the only workaround is to accept signature with an expired key... or wait for the next release to update it...

from docker-tor-hidden-service.

cmehay avatar cmehay commented on August 29, 2024

yes please do,

Thanks

from docker-tor-hidden-service.

NoNamePro0 avatar NoNamePro0 commented on August 29, 2024

Any updates, relating this issue?

from docker-tor-hidden-service.

cmehay avatar cmehay commented on August 29, 2024

I don't find any satisfying workaround so I'm removing the signature check.

It should be good as long the repository is cloned from https://git.torproject.org/tor.git which is already authenticated by TLS.

from docker-tor-hidden-service.

NoNamePro0 avatar NoNamePro0 commented on August 29, 2024

hmm, okay. Maybe do that with git submodules.

from docker-tor-hidden-service.

schildbach avatar schildbach commented on August 29, 2024

I'm closing this as the issue has been resolved via b7bf5f6.

from docker-tor-hidden-service.

NoNamePro0 avatar NoNamePro0 commented on August 29, 2024

Great!

from docker-tor-hidden-service.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.