GithubHelp home page GithubHelp logo

Comments (5)

AEtheve avatar AEtheve commented on June 5, 2024

I fixed it temporarily by replacing
if (isTls) { in application.ts
with :
if (isTls && typeof options.certFile == "string" && typeof options.keyFile == "string") {

from opine.

cmorten avatar cmorten commented on June 5, 2024

Yeah seems types just slightly mismatching now.

ListenTlsOptions have all pertinent keys as optional https://doc.deno.land/deno/stable/~/Deno.ListenTlsOptions which is inherited by opine’s HTTPSOptions https://github.com/cmorten/opine/blob/main/src/types.ts#L22 so isTls isn’t quite cutting it anymore.

Think solution would be to adjust HTTPSOptions defined in opine’s types to have the key and cert keys as non-optional.

from opine.

AEtheve avatar AEtheve commented on June 5, 2024

Ok, fine, that's what I thought, thanks.

from opine.

cawoodm avatar cawoodm commented on June 5, 2024

Sorry, what's the fix here? I'm getting this error with opine 2.1.4 AFAIK the latest version.

from opine.

cmorten avatar cmorten commented on June 5, 2024

@cawoodm what is the error you are seeing? The fix for this issue was to use latest opine on latest deno (deno upgrade).

If you're still facing issues, feel free to raise a new issue with the error you are seeing

from opine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.