GithubHelp home page GithubHelp logo

Comments (2)

bamos avatar bamos commented on September 28, 2024

From @bgilbert in #28:

Since Filter is supposed to be generic, and only the caller will know what filters are actually available, FilterEnum and Filter.loadFilters() are problematic. It would be better to have the Filter constructor take a resource ID, and unpack the specified filter (and only that filter) itself.

Also, unpacking will need some work, because it shouldn't be done from the UI thread as it isnow.

from diamond-android.

bamos avatar bamos commented on September 28, 2024

I originally had the Enum wrapping res objects so the library could include
a default set of resources. The Enum was necessary because
applications using the library couldn't access the library's resources
directly.

I've removed the enum and the library's Filter class now loads the
resource ID from the application's resources.
I'm leaving this issue open for a binary constructor for Filter to be
added in the future.

from diamond-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.