Comments (7)
Out of curiosity, was this addressed and was it confirmed the breaking change was intentional? Best practice is to expose the "common default port your application runs on", which in this case is 8000. I think the original Dockerfile allowed for the port to be changed already by overriding the command, so I don't think this change was really necessary.
from docker-dynamodb-local.
Not that I'm aware of - I only closed the issue because it has been over a month with no response/acknowledgement. I assumed no one had any intention to address the issue and/or not many people were bitten by the issue.
I'm happy to reopen if it's something people care about.
from docker-dynamodb-local.
It looks like the change was ported to the different versions and published yesterday, so maybe more people will care now. I wound up here because it broke my build.
from docker-dynamodb-local.
First of all, sorry for the late response. I was on month+ long vacation.
@Druotic Thanks for bringing it up.
@mchristiansen Thanks for your inputs.
I agree that EXPOSE 8000
should be in Dockerfile. The original change went in without documentation also. I'll fix it soon.
I'm curious to know your use case that relies on --publish-all/-P
.
from docker-dynamodb-local.
It should all be good now. Please take a look at the fix, validate and confirm.
from docker-dynamodb-local.
Fix looks good to me. Thank you for looking at this.
I am using the docker-java library to create containers to use during testing. After some digging I found an issue that pointed out that the docker-java library forces you to explicitly declare exposed ports not included in the image, so I was inadvertently dependent on the image declaring the exposed port. For whatever reason this is different behavior than if you just use the command line -p
option, which does it automatically.
Adding the explicit exposed ports to the create container command fixed my problem, but I thought it worth bringing up since it seemed better for it to be there in the image as well.
from docker-dynamodb-local.
Thanks for the confirmation.
Got it. Thanks for the explanation.
from docker-dynamodb-local.
Related Issues (7)
- Limit java heap size HOT 5
- 2020-01-24 is broken? HOT 2
- Connection Refused for DynamoDB HOT 9
- Add inMemory option HOT 4
- 2018-04-11 is broken HOT 4
- Checksum verification HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-dynamodb-local.