GithubHelp home page GithubHelp logo

Comments (5)

LocalSpook avatar LocalSpook commented on May 25, 2024 1

Commit d9189b4 didn't fix the issue. The new names (for example, _VLA_HEADER_DYNARRAY_HPP_) still have leading underscores.

from dynarray.

cnbatch avatar cnbatch commented on May 25, 2024 1

Truely sorry about that.
Please try the new version, I have now deleted the underscores at the beginning of the macros.

from dynarray.

cnbatch avatar cnbatch commented on May 25, 2024

The macros have been updated to prevent the use of reserved names.

Thank you for your valuable suggestion!

from dynarray.

jwakely avatar jwakely commented on May 25, 2024

Nice, thanks!

from dynarray.

jwakely avatar jwakely commented on May 25, 2024

Right, that's just as bad (I didn't check the actual code, just assumed what was said here was correct).

The problem is not that the names don't end in "HPP" it's that the start with an underscore followed by an uppercase letter. _VLA_DYNARRAY is bad, VLA_DYNARRY is good. If you want so use XXX_HEADER_XXX_HPP that's fine, but it can't use a leading underscore.

from dynarray.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.