German sample in LanguageToolBearTest isn't good german about coala-bears

[Adrianzatreanu]

why is this a type/test?

[AbdealiLoKo]

Because it's a sentence that needs to be changed in a test file

[Hazen91]

I can do it if you like

[Adrianzatreanu]

Hi! Welcome to our community and thank you for your interest!

I have sent you an invitation to join our community. This is needed so we can coordinate tasks with you and make sure no two persons are working on the same thing. If you can't find the mail, you should be able to join us at http://github.com/coala/!

We'd love to be able to help you when problems occur. Just join us on our gitter channel and tell us about them :)

[daminisatya]

Hey @sils1297 Is this issue fixed ? Can i make my first contribution to coala here ?

[Cosmopal]

I can look at it

[jayvdb]

@Cosmopal, do you understand German? Do you know what it should be changed to?

[keikoro]

The English sample in that file doesn't look like correct English either. ;P

[Cosmopal]

At least I think I do @jayvdb , I know a bit of it. Enough to correct that out. As I see it is copied from google translate, which is generally not a good idea.

[keikoro]

Maybe the English sentence should get fixed first though. German native speaker here, btw.

[keikoro]

(I'd suggest removing "Jedermann" in any case as it's gendered language.)

[Cosmopal]

@kerstin ok, will do so tomorrow

[keikoro]

I've submitted a fix because I don't see this getting done anymore based on no or slow reactions by would-be Hacktoberfest contributors.

However, it would have been really helpful if the gitmate-bot message/your particular contributing rules had already been mentioned or linked to from the beginning (especially for newcomers coming in through the Hacktoberfest tag)... I'm now being told to do x, y and z after submitting, so uhh, I guess I have to redo my commit so it aligns 100% with your contribution rules?

–> If any of you above want to redo it based on my suggested changes, feel free.

[keikoro]

(But please check gitmate-bot's message in the linked PR first. #935)

[sils]

@kerstin we do have a lot of newcomer issues and it's very hard to maintain them. We try to avoid duplicate assignments by making sure people are assigned to the issues they work on.

The stuff GitMate tells you should ideally be linked from the newcomers guide as well, but it's a good idea to put this "checklist" in there as well. We should pick that up. Do you have any other suggestions on how we can improve the workflow? Trust me, we're all volunteers and nobody is interested in you or anyone else wasting your time.

[keikoro]

Hey @sils, it could very well be that how you do things works fine for regular contributions because for these, would-be fixers will be folks who are already familiar with the project (most likely), and they'll be browsing the issues after having had a look around.

With the Hacktoberfest tag though, people just go through GitHub search for the tag and might not even check out the entire project & all available guidelines. So I'm guessing it would have made sense to explicitely make people aware of them when you added the tag to issues. Too late for that now (: but maybe something to keep in mind for next time.

[keikoro]

I'll check back in in November and redo the commit so it follows the guidelines if it hasn't been picked up by anyone else until then in any case. As said above: if anyone else wants to do the PR until then to fill their Hacktoberfest quota to get a shirt from DigitalOcean, I'm happy to let them reuse my suggested changes. ^^