Comments (19)
From @AbdealiJK on February 9, 2016 5:43
The skip condition to be to check if go help vet
returns 0 or not
from coala-bears.
From @NalinG on February 9, 2016 10:11
Hi, I would like to work on this issue.
I checked the GoVetBear.py file but is just called the self.lint method.
Do we have to change the lint method or I am missing something.
Thank You
from coala-bears.
From @AbdealiJK on February 9, 2016 10:30
The ship condition is in GoVetBearTest
The @SkipIf checks for go, not for go vet
-----Original Message-----
From: "Nalin Goel" [email protected]
Sent: 09-02-2016 15:41
To: "coala-analyzer/coala" [email protected]
Cc: "AbdealiJK" [email protected]
Subject: Re: [coala] GoVetBear - skip condition invalid (#1329)
Hi, I would like to work on this issue.
I checked the GoVetBear.py file but is just called the self.lint method.
Do we have to change the lint method or I am missing something.
Thank You
—
Reply to this email directly or view it on GitHub.
from coala-bears.
@NalinG please work only on one newcomer issue, we don't have a lot of them because they take a lot of work to create.
from coala-bears.
From @NalinG on February 9, 2016 18:41
Sorry for the trouble.
I will take care in the future.
from coala-bears.
no problem
from coala-bears.
Hey @sils1297, I'd like to work on this issue! :)
from coala-bears.
@AbdealiJK using which('go help vet ')
returns None
even though I have go vet
installed.
I can use os.system('go help vet')
in place for checking installation. Thoughts ?
from coala-bears.
'which' doesn't work like that. It only accepts 1 arg. What were you expecting 'which go vet bear' to give???
Instead of os.system() we use sub process.check_call or subprocess.check_output. Look at other bears and how it's implemented in them.
from coala-bears.
I realised that after posting the comment. Sure, I'll do that!
Thanks.
from coala-bears.
Please see the new GoRequirement . Each bear should not do their own package management checks - they will be buggy.
from coala-bears.
(Go vet is a bit special, but its specialness should be in GoRequirement)
from coala-bears.
@jayvdb I'm not sure if you're pointing to any specific part of the documentation.
Can you give a link for where I can see the GoRequirement..
from coala-bears.
@jayvdb but we need to ensure it works for the test skipping right? Or has that been offloaded to GoRequirements?
CC @Adrianzatreanu
from coala-bears.
See coala/coala#2752 , which fixed GoRequirement.is_installed
for the general case. Special tests might be needed for go vet
.
Test skipping should be done using GoRequirement.is_installed
, and can probably be done dynamically in LocalBearTestHelper
as the requirement is declared in the bear.
from coala-bears.
@AbdealiJK @jayvdb So the condition for checking go vet
should be implemented in GoRequirement.is_installed
or should I put it in GoVetBear.py
inplace of which(go)
implementation ?
from coala-bears.
Ideally it'd be in GoRequirement.is_installed done properly and then the Bear class should automatically use those. CC @Makman2 and @Udayan12167 as this affects the Bear and LintBase classes
from coala-bears.
@sils Since @Makman2 is working on this issue, should I pick a different newcomer
issue ?
from coala-bears.
@manu-chroma sure, if you like. Not sure what @Makman2 is planning
from coala-bears.
Related Issues (20)
- RuboCopBear: caught error with --stdin flag HOT 1
- Coala stuck at rstcheck
- Coala bears requires Click version 6.6
- Indentation Error on trying PEP8Bear. HOT 1
- licensecheck integration
- Bear Proposal: Scancode-Toolkit
- Throughput Graph in readme.rst file does not show image.
- install fails with pipenv under python 3.6, via pyyaml HOT 2
- Consider adding SystemVerilog support by collaborating with Verible + Surelog HOT 1
- Fix Bandit version to 1.6.2 to fix CI
- Moban Sync
- pkg_resources.ContextualVersionConflict
- language-check install breaking pipeline HOT 3
- https://coala.io/#/languages search broken HOT 2
- Facing
- [HELP] Facing dependecy issue while installing requirements files of coala bears.
- Dependency [guess-language-spirit] cannot be found.
- Error when building 'typed-ast' from 'Development Setup Notes'
- AttributeError: module 'collections' has no attribute 'Callable'
- VerilogLintBear - minor fix for Verilator lint HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coala-bears.