Error: git submodules have not been initialized about covenant

[cobbr]

Hey @Comanio00, I'm going to guess that you have not re-built Covenant since you pulled down the latest copy? We have to be sure that the container has the submodules, not just the docker host.

First, verify that you initialized the submodules properly:

$ ~/Covenant/Covenant > ls Data\Tasks\src\SharpSploit
CHANGELOG.md      README.md         SharpSploit.Tests
LICENSE           SharpSploit       SharpSploit.sln
$ ~/Covenant/Covenant > ls Data\Tasks\src\Rubeus
CHANGELOG.md LICENSE      README.md    Rubeus       Rubeus.sln

Now that we know you have the submodules, let's make sure the submodules are present in the container:

$ ~/Covenant/Covenant > docker exec -it covenant ls /app/Data/Tasks/src/SharpSploit
CHANGELOG.md  README.md    SharpSploit.Tests
LICENSE       SharpSploit  SharpSploit.sln
$ ~/Covenant/Covenant > docker exec -it covenant ls /app/Data/Tasks/src/Rubeus
CHANGELOG.md  LICENSE  README.md  Rubeus  Rubeus.sln

Assuming that your docker host has the submodules, but your container does not, then give this a try:

$ ~/Covenant/Covenant > docker stop covenant
$ ~/Covenant/Covenant > docker rm covenant
$ ~/Covenant/Covenant > docker build -t covenant .
$ ~/Covenant/Covenant > docker run -it -p 7443:7443 -p 80:80 -p 443:443 --name covenant -v /absolute/path/to/Covenant/Covenant/Data covenant --username AdminUser --computername 0.0.0.0

[cobbr]

Went ahead and added details on using docker's -v parameter to the README. This may make things easier for you, and I've been meaning to make this change anyway.

7bfb67b

[dtrizna]

Had the same problem after last commit.
Acknowledge that volume mount with -v solves it.

[cobbr]

Turns out there was an issue with Docker not copying over the correct files that Covenant was checking for existence of the submodules.

Pushed out a fix df42fcd
Let me know if you still have issues. You should be able to use the -v parameter or not.

[Comanio00]

Thank you.
This decision helped. Everything is working.

When starting Covenant a warning appears:

Password: *******
Hosting environment: Development
Content root path: /app
Now listening on: http://0.0.0.0:80
Using Covenant certificate with hash: 3F03FC3C0AB9E88467A3CB94E0D9DF6624AC02B3
warn: Microsoft.AspNetCore.Server.Kestrel[0]
Overriding address(es) 'http://+:80'. Binding to endpoints defined in UseKestrel() instead.
Hosting environment: Development
Content root path: /app
Now listening on: https://0.0.0.0:7443
Application started. Press Ctrl+C to shut down.
warn: Microsoft.EntityFrameworkCore.Query[10103]
Query: '(from HttpListener _1 in DbSet select [_1]).FirstOrDefault()' uses First/FirstOrDefault/Last/LastOrDefault operation without OrderBy and filter which may lead to unpredictable results.

How can this affect the Covenant?

[cobbr]

Hey @Comanio00, that's expected. Maybe eventually it's something I should address.