Comments (7)
Seen https://github.com/cockroachlabs/support/issues/2998
from cockroach.
As a follow-up, we should ensure other jobs kicked off by schema changes also get this override.
To tag on, we might want to audit if other session variables would land us in a similar spot.
from cockroach.
Actually, we can just make all background jobs ignore the statement timeout in here
Lines 1131 to 1150 in b9680b4
from cockroach.
I think this diff might be what we want. We could update the comment on NewInternalSessionData
to indicate this.
diff --git a/pkg/sql/internal.go b/pkg/sql/internal.go
index 24685b16219..cfb161132b4 100644
--- a/pkg/sql/internal.go
+++ b/pkg/sql/internal.go
@@ -95,6 +95,7 @@ func NewInternalSessionData(
sd.SearchPath = sessiondata.DefaultSearchPathForUser(username.NodeUserName())
sd.SequenceState = sessiondata.NewSequenceState()
sd.Location = time.UTC
+ sd.StmtTimeout = 0
return sd
}
from cockroach.
For people who are affected by this right now, we can recommend that they configure the default statement_timeout
using ALTER ROLE ALL SET statement_timeout = ...
rather than the sql.defaults.statement_timeout
cluster setting.
from cockroach.
i'll leave this open until i take care of my backports
from cockroach.
Re-opening as per https://cockroachlabs.slack.com/archives/C0168LW5THS/p1723150249619579
from cockroach.
Related Issues (20)
- cli: TestCollectInfoFromMultipleStores failed HOT 2
- cli: better guardrail against max-offset misconfiguration
- ldr: job description does not include options for the stream HOT 1
- Sentry: cmd_recover_txn.go:137: failed indeterminate commit recovery: programming error: timestamp change by implicitly committed transaction: 1723643040.130253201,2->1723643033.473852808,2 (1) Wraps:...
- REST API to set cluster settings
- kv: manually compact liveness range periodically
- cdc: 24.3 release checklist HOT 1
- roachtest: import/tpcc/warehouses=4000/geo failed
- ccl/crosscluster/logical: TestLogicalJobResiliency failed
- CREATE CHANGEFEED attempts to create a "{_family_}" topic in downstream sink HOT 1
- server: TestCachedSettingsServerRestart failed
- pkg/sql/logictest/tests/cockroach-go-testserver-24.1/cockroach-go-testserver-24_1_test: TestLogic_mixed_version_can_login failed
- Altering recurrence on paused backup schedules will only automatically resume the incremental schedule HOT 3
- sql: implement data collection for UpdateCachedTableMetadata HOT 2
- *: audit cluster settings
- ALTER BACKUP SCHEDULE should not automatically resume schedules HOT 2
- Sentry: syncing_file.go:65: write ×: bad address (1) attached stack trace -- stack trace: | runtime.gopanic | GOROOT/src/runtime/panic.go:770 | github.com/cockroachdb/cockroach/pkg/storage.(...
- roachprod: use NVMe when provisioning clusters on Azure HOT 1
- Sentry: panic.go:914: runtime error: invalid memory address or nil pointer dereference (1) attached stack trace -- stack trace: | runtime.gopanic | GOROOT/src/runtime/panic.go:914 | runtime.p...
- schemachanger: declarative schema changer does not support `NaN` as a default value in a function
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cockroach.