ccl/backupccl: TestOnlineRestoreBasic failed about cockroach

[cockroach-teamcity]

ccl/backupccl.TestOnlineRestoreBasic failed with artifacts on master @ 6b22014dec8c5e8e6006d710ed05bab5b01b4ae2:

=== RUN   TestOnlineRestoreBasic
    test_log_scope.go:170: test logs captured to: /artifacts/tmp/_tmp/44cc1cc0ef77f902d6c266f2a388abb1/logTestOnlineRestoreBasic3049318939
    test_log_scope.go:81: use -show-logs to present logs inline
    testutils.go:299: no Invalid Descriptors
    testutils.go:299: no Invalid Descriptors
    restore_online_test.go:96: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/44cc1cc0ef77f902d6c266f2a388abb1/logTestOnlineRestoreBasic3049318939
--- FAIL: TestOnlineRestoreBasic (5.57s)
=== RUN   TestOnlineRestoreBasic/incremental=true
    restore_online_test.go:90: query 'SELECT create_statement FROM [SHOW CREATE TABLE data.bank]': expected:
        CREATE TABLE public.bank (
        	id INT8 NOT NULL,
        	balance INT8 NULL,
        	payload STRING NULL,
        	CONSTRAINT bank_pkey PRIMARY KEY (id ASC),
        	FAMILY fam_0_id_balance_payload (id, balance, payload)
        )
        
        got:
        CREATE TABLE public.bank (
        	id INT8 NOT NULL,
        	balance INT8 NULL,
        	payload STRING NULL,
        	CONSTRAINT bank_pkey PRIMARY KEY (id ASC),
        	FAMILY fam_0_id_balance_payload (id, balance, payload)
        ) WITH (sql_stats_automatic_collection_enabled = false)
        
    --- FAIL: TestOnlineRestoreBasic/incremental=true (1.34s)

Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

[stevendanna]

We think this is caused by a missing ORDER BY in the query that waits for the job to complete.