Saving a Cordova .pbxproj breaks about nanaimo

[segiddins]

Please share steps to reproduce the issue, thanks!

[mmerickel]

I just ran into this (similar) issue because I was passing a Pathname object to a Xcodeproj::Project::Object::XCConfigurationList#build_configuration_list#set_setting. It appears the Nanaimo::Writer#write_object method is quite strict on what it accepts and may need to be relaxed.

[segiddins]

@mmerickel you should be setting it as a string

[mmerickel]

@segiddins It worked before upgrading.

[segiddins]

Sorry, you're right. Can you share a code snippet that reproduces the problem?

[mmerickel]

#!/usr/bin/env ruby

require 'pathname'
require 'xcodeproj'

project_path = Pathname.new('DummyProject.xcodeproj')
plist_path = Pathname.new('DummyProject/Info.plist')

project = Xcodeproj::Project.new(project_path)

target = project.new_resources_bundle('DummyProjectBundle', :ios)
target.build_configuration_list.set_setting('INFOPLIST_FILE', plist_path)

project.save

produces the following stacktrace:

/Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:63:in `write_object': Cannot write DummyProject/Info.plist to an ascii plist (RuntimeError)
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:140:in `write_dictionary_key_value_pair'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/xcode_project_writer.rb:41:in `write_dictionary_key_value_pair'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:119:in `block in write_dictionary'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:118:in `each'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:118:in `write_dictionary'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/xcode_project_writer.rb:19:in `write_dictionary'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:55:in`write_object'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:140:in `write_dictionary_key_value_pair'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/xcode_project_writer.rb:41:in `write_dictionary_key_value_pair'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:119:in `block in write_dictionary'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:118:in `each'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:118:in `write_dictionary'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/xcode_project_writer.rb:19:in `write_dictionary'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:55:in`write_object'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:140:in `write_dictionary_key_value_pair'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/xcode_project_writer.rb:41:in `write_dictionary_key_value_pair'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/xcode_project_writer.rb:29:in `block (2 levels) in write_dictionary'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/xcode_project_writer.rb:28:in `each'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/xcode_project_writer.rb:28:in `block in write_dictionary'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/xcode_project_writer.rb:24:in `each'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/xcode_project_writer.rb:24:in `write_dictionary'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:55:in`write_object'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:140:in `write_dictionary_key_value_pair'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/xcode_project_writer.rb:41:in `write_dictionary_key_value_pair'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:119:in `block in write_dictionary'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:118:in `each'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:118:in `write_dictionary'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/xcode_project_writer.rb:19:in `write_dictionary'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:55:in`write_object'
        from /Users/michael/.gem/ruby/2.0.0/gems/nanaimo-0.1.4/lib/nanaimo/writer.rb:29:in`write'
        from /Users/michael/.gem/ruby/2.0.0/gems/xcodeproj-1.4.0/lib/xcodeproj/project.rb:353:in `block in save'
        from /Users/michael/.gem/ruby/2.0.0/gems/xcodeproj-1.4.0/lib/xcodeproj/project.rb:353:in `open'
        from /Users/michael/.gem/ruby/2.0.0/gems/xcodeproj-1.4.0/lib/xcodeproj/project.rb:353:in `save'
        from ./reproduce_8.rb:14:in `<main>'

However, using plist_path.to_s fixes it.

[segiddins]

Thanks!