Comments (1)
Since we are funding the loan for amt
, the approval is always set to zero. Since we cannot increase the approval in any other way, the approval will always be zero when it is set the next time.
from 2021-04-maple-findings.
Related Issues (20)
- Interface and implementation function declaration differs HOT 1
- Function triggerDefault should call _emitBalanceUpdateEventForCollateralLocker HOT 1
- LoanLib.unwind uses globals.fundingPeriod() HOT 1
- zero cooldown should be explicitly allowed as per comment HOT 1
- contract MapleTreasury should not allow to reclaim fundsToken HOT 1
- getRewardForDuration will start returning misleading results if rewardsDuration is updated HOT 1
- Contract MplRewards should have an emergency withdraw function HOT 2
- Uniswap DOS HOT 1
- Default slippage value too high HOT 4
- FundsWithdrawn event emitted when amount withdrawn is 0 HOT 1
- Not ERC20 Compliant HOT 1
- Slippage should not be allowed to be set to very high values HOT 3
- Oracle not checked if set for an asset HOT 2
- Any valid liquidator can arbitrage from the loan contract to earn collateral assets by exploiting the maximum slippage when defaulting a loan. HOT 2
- Full payment does not consider late fees of the payment HOT 5
- Functions calculating the value of `BPT` is vulnerable to flash-loan attacks. HOT 3
- Bypass or reduction on the lockup period. HOT 1
- Potential reentrancy when the borrower drawdowns the loan. HOT 2
- Unnecessary `transferOwnership` funciton call in `MplRewards.sol` and `oracle/ChainlinkOracle.sol`. HOT 1
- Bypass or reduction on the lockup period of Pool FDTs. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2021-04-maple-findings.