Comments (3)
This is directly related to #29 as it refers to the same workflow, as seen in #74 as a single submission. I believe splitting this into two findings is unfair for the first party and secondly, it does not make sense because there is a valid argument for disagreeing with the severity seen on #74. Can we close this and merge it with #29?
from 2021-05-fairside-findings.
Fixed in PR#3.
from 2021-05-fairside-findings.
Labeling issues #29 and #30 as separate issues because they both pose major issues, which lead to temporary loss of funds, in two different workflows. One when tokenizing convictions and another when acquiring convictions.
from 2021-05-fairside-findings.
Related Issues (20)
- Check if variables are initialized HOT 2
- lack of input validation of id in getConvictionScore(){} HOT 2
- convictionless mapping is not used HOT 2
- Chainlink Price data could be stale HOT 1
- The function liquidateDai() fails HOT 2
- Revert messages are wrong HOT 1
- Magic number is used multiple times in the contracts `FSDNetwork` and `ABC` HOT 3
- Unlock pragma used in multiple contracts HOT 2
- Solidity keyword `transfer` is used in the contract `Withdrawable` HOT 2
- Wrong function called in `addRegistrationTributeGovernance` HOT 1
- Events in `FairSideDAO` are not indexed HOT 2
- Should check return data from Chainlink aggregators HOT 2
- Gas optimization for the `rootPows` function in `FairSideFormula` HOT 3
- `pendingWithdrawals` not decreased after a `withdraw` HOT 2
- Incorrect implementation of arctan in the contract `FairSideFormula` HOT 1
- Users are charged twice the FDT tokens when tokenizing their convictions HOT 3
- The variable `fShareRatio` is vulnerable to manipulation by flash minting and burning HOT 3
- Flash minting and burning can reduce the paid fees when purchasing a membership or opening a cost share request HOT 4
- Incorrect type conversion in the contract `ABC` makes users unable to burn FSD tokens HOT 1
- Incorrect type conversion in the contract `ABC` makes users unable to burn FSD tokens HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2021-05-fairside-findings.