Comments (2)
HickupHH3
commented on July 28, 2024
ETH can accidentally be sent to a contract that rejects the transfer because the sent value returned by address(_to).call{value: receivedETHAmount}(''); is not actually checked.
https://github.com/code-423n4/2022-05-sturdy/blob/main/smart-contracts/LidoVault.sol#L140-L142
On line 140 a call is made to transfer ETH (bool sent, bytes memory data) = address(_to).call{value: receivedETHAmount}('');
Then on line 141 receivedETHAmount is returned.
And on line 142 the sending of ETH is checked.
Recommended Mitigation Steps
To fix this, line 141 and line 142 should be swapped.
from 2022-05-sturdy-findings.
HickupHH3
commented on July 28, 2024
Duplicate of #157
from 2022-05-sturdy-findings.
Related Issues (20)
- Return value of send of ether not checked in `_withdrawFromYieldPool` HOT 1
- The check for value transfer success is made after the return statement in _withdrawFromYieldPool of LidoVault HOT 1
- QA Report HOT 1
- Gas Optimizations
- QA Report HOT 1
- Subsequent calls to ConvexCurveLPVault's setConfiguration function by admin erases existing Sturdy tokens HOT 2
- Gas Optimizations HOT 5
- QA Report HOT 1
- unsual token.decimals() would be trigger unsual behavior HOT 2
- Initialization function can be front-run HOT 2
- QA Report HOT 1
- LidoVault: require(msg.value == 0);
- Upgraded Q -> H from 69 [1654495749150] HOT 2
- Upgraded Q -> H from 103 [1654497033247] HOT 2
- Upgraded Q -> M from 103 [1654497041670] HOT 2
- Upgraded Q -> M from 135 [1654503715861] HOT 2
- Upgraded Q -> M from 135 [1654503723748] HOT 1
- Upgraded Q -> H from 135 [1654503748167] HOT 1
- Agreements & Disclosures
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2022-05-sturdy-findings.