Comments (7)
Fixed in infinitydotxyz/exchange-contracts-v2@bbbd362
from 2022-06-infinity-findings.
from 2022-06-infinity-findings.
from 2022-06-infinity-findings.
from 2022-06-infinity-findings.
from 2022-06-infinity-findings.
from 2022-06-infinity-findings.
There were several reports of this issue. Accepting this one as the primary since it's the best description that also included a test demonstrating the problem. This helps a lot to understand and confirm the issue.
This is a High risk issue. The PoC demonstrates how a maker specifying a bundle of NFTs could incorrectly have one ERC1155 item in that bundle processed several times by the taker - the bundle is not fully accepted as expected, the item processed multiple times is essentially overfilled, and this may be abused to the taker's advantage when the NFTs are not valued the same.
from 2022-06-infinity-findings.
Related Issues (20)
- QA Report
- Gas Optimizations HOT 1
- Continuous staking within same duration prolongs staking token vesting time HOT 2
- QA Report HOT 4
- Consistently check account balance before and after transfers for Fee-On-Transfer discrepancies HOT 2
- QA Report
- _transferNFTs can end up transferring nothing HOT 3
- Gas Optimizations HOT 1
- Gas Optimizations HOT 1
- The owner can set arbitrarly high fees HOT 2
- Disregard
- Disregard
- Disregard
- Disregard
- Disregard
- Disregard
- Upgraded Q -> M from 270 [1657580270573] HOT 1
- Upgraded Q -> M from 270 [1657580410834] HOT 1
- Upgraded Q -> H from 187 [1657760940788] HOT 1
- Upgraded Q -> H from 19 [1657761554720] HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2022-06-infinity-findings.