GithubHelp home page GithubHelp logo

Comments (6)

drgorillamd avatar drgorillamd commented on July 28, 2024 1

@csanuragjain indeed, reopened 11 to give it another look, it kinda feels like a different issue tho

from 2022-10-juicebox-findings.

drgorillamd avatar drgorillamd commented on July 28, 2024

This is not an issue, user can delegate votes at will (including delegating to another address later after delegating to address(0)), same as they can transfer to address(0) or vb.eth if they want.

from 2022-10-juicebox-findings.

csanuragjain avatar csanuragjain commented on July 28, 2024

@drgorillamd
It wont be possible to delegate to other address post delegating to address 0. The reason being _moveTierDelegateVotes will only deduct vote and not increase. I have given detailed explanation at issue number 11
Can you please suggest

from 2022-10-juicebox-findings.

Picodes avatar Picodes commented on July 28, 2024

The warden has not showed why the user won't be able to delegate to other address post delegating to address(0). Downgrading to QA has this issue only highlights a missing sanity check.

from 2022-10-juicebox-findings.

c4-judge avatar c4-judge commented on July 28, 2024

Picodes changed the severity to QA (Quality Assurance)

from 2022-10-juicebox-findings.

c4-judge avatar c4-judge commented on July 28, 2024

Picodes marked the issue as grade-b

from 2022-10-juicebox-findings.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.