Comments (6)
@csanuragjain indeed, reopened 11 to give it another look, it kinda feels like a different issue tho
from 2022-10-juicebox-findings.
This is not an issue, user can delegate votes at will (including delegating to another address later after delegating to address(0)
), same as they can transfer to address(0) or vb.eth if they want.
from 2022-10-juicebox-findings.
@drgorillamd
It wont be possible to delegate to other address post delegating to address 0. The reason being _moveTierDelegateVotes will only deduct vote and not increase. I have given detailed explanation at issue number 11
Can you please suggest
from 2022-10-juicebox-findings.
The warden has not showed why the user won't be able to delegate to other address post delegating to address(0)
. Downgrading to QA has this issue only highlights a missing sanity check.
from 2022-10-juicebox-findings.
Picodes changed the severity to QA (Quality Assurance)
from 2022-10-juicebox-findings.
Picodes marked the issue as grade-b
from 2022-10-juicebox-findings.
Related Issues (20)
- Gas Optimizations HOT 2
- Gas Optimizations HOT 1
- If the "renounceOwnership" authorization is used, the project becomes unavailable HOT 5
- QA Report HOT 2
- Very critical `Owner` privileges can cause damage of the project in a possible privateKey exploit HOT 4
- Gas Optimizations HOT 1
- QA Report HOT 2
- JBTiered721Delegate.tokenURI() is not compliant with EIP721 HOT 2
- No access control for function deployDeletateFor HOT 3
- QA Report HOT 1
- Gas Optimizations HOT 1
- Usage of unsafe `_mint()` function HOT 4
- Gas Optimizations HOT 1
- Gas Optimizations HOT 1
- Unsafe downcast operations can lead to silent failures HOT 3
- # Potential unbounded loops in `JBTiered721DelegateStore` HOT 7
- QA Report HOT 1
- QA Report HOT 1
- Gas Optimizations HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2022-10-juicebox-findings.