Comments (4)
saxenism (sponsor) disputed
from 2024-03-zksync-findings.
Not an issue. The only reason why mintEther can fail, while keeping enough gas to execute nearCallPanic() itself is if 63/64 of the gas of the parent frame was passed and it wasnt enough. We must use nearCallPanic to protect ourselves from malicious users supplying too few gas.
from 2024-03-zksync-findings.
The Warden denotes that gas will be forcibly burnt if an ether mint fails at the L2 level which may be considered unfair. Per the Sponsor's assessment and the code's implementation, the scenario under which an ether mint will fail can only be considered as "malicious" in the sense that the caller did not supply sufficient gas.
In such a case, burning any remaining gas is an acceptable error handling mechanism as the gas itself should be minuscule and the ether mint's failure indicates abnormal circumstances (i.e. significantly small gas allocated).
from 2024-03-zksync-findings.
alex-ppg marked the issue as unsatisfactory:
Invalid
from 2024-03-zksync-findings.
Related Issues (20)
- Gas Optimizations HOT 3
- No way to retrieve ETH from the contract: HOT 5
- Large transfers may not work with some ERC20 tokens HOT 4
- Gas Optimizations HOT 3
- `L2StandardERC20.sol` has a flaw in token's reinitialization logic cause after a while the governor would not be able to update the token's metadata HOT 4
- QA Report HOT 2
- QA Report HOT 7
- Gas Optimizations HOT 3
- Gas Optimizations HOT 3
- Gas Optimizations HOT 5
- Gas Optimizations HOT 5
- Centralization risks around `Governance.sol` HOT 7
- Gas Optimizations HOT 3
- QA Report HOT 2
- QA Report HOT 2
- QA Report HOT 2
- QA Report HOT 2
- Upgraded Q -> 2 from #122 [1714762888728] HOT 2
- Upgraded Q -> 2 from #60 [1714762986225] HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2024-03-zksync-findings.