Comments (8)
c4-judge
commented on September 2, 2024
0xA5DF marked the issue as primary issue
from 2024-04-gondi-findings.
0xend
commented on September 2, 2024
We should get rid of this one. This was left as legacy (only improving apr matters).
from 2024-04-gondi-findings.
0xA5DF
commented on September 2, 2024
Thanks, it indeed seems from the code that those checks were supposed to run, therefore this is a valid issue.
However, regarding severity - I fail to see why this is a significant issue - how does this impact the borrower or other users?
Marking as low for now
from 2024-04-gondi-findings.
c4-judge
commented on September 2, 2024
0xA5DF changed the severity to QA (Quality Assurance)
from 2024-04-gondi-findings.
0xend
commented on September 2, 2024
No impact on borrower/lender
from 2024-04-gondi-findings.
0xend
commented on September 2, 2024
https://github.com/pixeldaogg/florida-contracts/pull/361 changing
from 2024-04-gondi-findings.
0xA5DF
commented on September 2, 2024
Moving to #70
from 2024-04-gondi-findings.
c4-judge
commented on September 2, 2024
0xA5DF marked the issue as grade-c
from 2024-04-gondi-findings.
Related Issues (20)
- The `getMaxTranches` check can be bypassed HOT 2
- Division before multiplication could lead to users losing 50% in WithdrawalQueue HOT 4
- Merging tranches could make `_loanTermination()` accounting incorrect HOT 4
- QA Report HOT 4
- Analysis HOT 2
- Lender can refinance a worse loan for the borrower through addNewTranche, due to missing checks HOT 4
- QA Report HOT 2
- The check on unlocked loan during refinance can be bypassed in addNewTranche HOT 3
- A malicious user can take on a loan using an existing borrower's collateral in refinanceFromLoanExecutionData() HOT 7
- Anyone can call `UserVault::mint` for any deployed vault HOT 4
- A borrower can use a wrong collateral nft token to refinance from a new loan offer HOT 3
- Gas Optimizations HOT 2
- Invalid maxTranches check can result in maxTranche cap to be exceeded HOT 4
- Loan hashing method is missing protocolFee field, which allows 0 or incorrect protocolFee to pass in multiple flows. ProtocolFees can be lost. HOT 3
- QA Report HOT 2
- Analysis HOT 1
- Upgraded Q -> 2 from #82 [1713691250926] HOT 2
- Upgraded Q -> 3 from #70 [1713692031143] HOT 4
- Upgraded Q -> 3 from #35 [1713794205670] HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 2024-04-gondi-findings.