GithubHelp home page GithubHelp logo

Comments (15)

bhutoria avatar bhutoria commented on July 26, 2024 1

How did you solve it? can you check the file changes in the pr and let me know if you had a different approach? thanks.

from daily-code.

mvp5464 avatar mvp5464 commented on July 26, 2024

Hi, @hkirat Sir, I have completed this assignment. Should I go for PR

from daily-code.

bhutoria avatar bhutoria commented on July 26, 2024

Hey @mvp5464 , I didn't know that we had to create an issue first. As a result I have already created a pull request #136 .

Did you use a similar approach, also, did you face the issue with ESLint as well regarding named exports?

from daily-code.

mvp5464 avatar mvp5464 commented on July 26, 2024

Ok then I will not create the PR for this issue.

Yes same problem.

from daily-code.

mvp5464 avatar mvp5464 commented on July 26, 2024

Added Revalidation whenever the backend endpoint is hit

  • We can add this to a button which is used to upload the notion docs (so if successfully uploaded then hit this link) [as TracksEditor.tsx is empty so not able to do that]
  • So It won't render in intervals but only when the notion doc is uploaded.
  • @hkirat sir, Is this good or need to add something else
Screencast.webm

from daily-code.

mvp5464 avatar mvp5464 commented on July 26, 2024

How did you solve it? can you check the file changes in the pr and let me know if you had a different approach? thanks.

In time duration I had done almost the same, But now changed to backend base, and it took almost 11 hrs

from daily-code.

bhutoria avatar bhutoria commented on July 26, 2024

Your backend revalidation request is something even I am trying. Can you share your implementation here?

from daily-code.

mvp5464 avatar mvp5464 commented on July 26, 2024

Your backend revalidation request is something even I am trying. Can you share your implementation here?

Sure, I am pushing PR but it is giving me type error

Does It look OK to you or should I make any further changes

from daily-code.

bhutoria avatar bhutoria commented on July 26, 2024

it looks good on the video.
can you share the code snippet here?
of the backend request function and implementation on the front end?

from daily-code.

mvp5464 avatar mvp5464 commented on July 26, 2024
  • So It won't render in intervals but only when the notion doc is uploaded.

Made PR So check it there and if any doubt or any suggestions mention me.

from daily-code.

bhutoria avatar bhutoria commented on July 26, 2024

Check out #141 .. your implementation is top notch, however shouldn't we add an api route to the next app since we are using the app router and not the pages router?

you can check out the code and let me know if I am assuming incorrectly.

from daily-code.

mvp5464 avatar mvp5464 commented on July 26, 2024

Hi @bhutoria, PR #138 has been created for this issue, so kindly close the duplicate PR #141.

I read that it may create conflict, So suggested to created this pages directory. page directory should be in the same level as the app directory. If this is wrong I will change my PR to add it back to an api route.

BTW, Thank you for your suggestions, and if have any doubt happy to help on this issue

from daily-code.

bhutoria avatar bhutoria commented on July 26, 2024

yeah, we are using Next v14, so we should use app router.

from daily-code.

mvp5464 avatar mvp5464 commented on July 26, 2024

OK, Thanks will update the PR

from daily-code.

mvp5464 avatar mvp5464 commented on July 26, 2024

closed #138

from daily-code.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.