share_ratio Decimal size about asset-declarations

[danniel]

On the other hand, in the Form field the app expects integers between 0 and 100 for percent_of_ownership and, on Task save, the data does not seem to be transformed to the database expected format for share_ratio.

That's why setting a percent_of_ownership to 0 or 1 or 9 works, while 10, 11, 99 raises <class 'decimal.InvalidOperation'> when trying to save data about Owned Buildings.

[RaduCStefanescu]

Great point @danniel
The way I see it the share_ratio should be in the form of 33.5 -> meaning 33.5%.
One way to implement this would be to implement a factory of model fields, that get as input just the name of the field. For example in our case, have a factory method that returns share_ratio type of fields, with 'max_digits=3' and 'decimal_places=1'.

[catileptic]

This is great digging and a great summary of the issue!

On the other hand, it occurs to me, reading this, that there might be people who have filled the asset declaration form in with a percent of 89.78. I hope this isn't the case, but what if it is?

Regardless, I think we should address this issue as part of the refactoring needed to merge this PR.

What do you think?

[danniel]

I will make all three fields to be max_digits=5, decimal_places=2

This way we can allow values as 100.00 for (100%)
A custom validator will prevent the input of values over 100.00