GithubHelp home page GithubHelp logo

Comments (9)

wincowgerDEV avatar wincowgerDEV commented on July 22, 2024

@shollingsworth is it trivial to write some instructions to verify the automated tests? Another thing I could probably do instead is just make a test set and then make a video explaining how someone could use it to verify behavior.

from trash-ai.

wincowgerDEV avatar wincowgerDEV commented on July 22, 2024

Perhaps adding this is actually enough: #124

If we add that to the downloads and then I explain how to use the schema validator tool like https://www.jsonschemavalidator.net/ in the updated video then that should be proof enough that the pipeline is working as expected to create a data output useful for users.

from trash-ai.

wincowgerDEV avatar wincowgerDEV commented on July 22, 2024

Got some additional feedback from the reviewers on this: openjournals/joss-reviews#5136 (comment)

@shollingsworth I think they are ok with us doing manual tests, but they would prefer we implement some automated user-side tests on the website/container using selenium or something similar if it isn't too crazy to implement.

from trash-ai.

Zesky665 avatar Zesky665 commented on July 22, 2024

@wincowgerDEV I read the suggestion in the JOSS thread. I can implement all of those tests using something like Cypress, it shouldn't be much of a hassle.

from trash-ai.

wincowgerDEV avatar wincowgerDEV commented on July 22, 2024

from trash-ai.

wincowgerDEV avatar wincowgerDEV commented on July 22, 2024

@Zesky665 should this be closed now thanks to your work in 8c56b8f?

from trash-ai.

Zesky665 avatar Zesky665 commented on July 22, 2024

@wincowgerDEV No, me and @shollingsworth still need to add the auto tests to the deployment workflow. We can declare it done after that.

from trash-ai.

wincowgerDEV avatar wincowgerDEV commented on July 22, 2024

from trash-ai.

wincowgerDEV avatar wincowgerDEV commented on July 22, 2024

Closing this because we added manual tests now.

from trash-ai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.