Testing Local Deployment Issues about trash-ai

[wincowgerDEV]

Right on, I made a PR for it and will add some updates there. Thanks :) #86

[shollingsworth]

I'll take a look at this @wincowgerDEV thanks.

[wincowgerDEV]

Thanks 🙏

…

On Fri, Nov 4, 2022, 12:02 AM Steven Hollingsworth ***@***.***> wrote: I'll take a look at this @wincowgerDEV <https://github.com/wincowgerDEV> thanks. — Reply to this email directly, view it on GitHub <#85 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGMUJU47HYKMYLJ6MQ6IPSLWGQ767ANCNFSM6AAAAAAROGAS3E> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[shollingsworth]

@wincowgerDEV can you have your friend Re-test to confirm the docs and build work correctly?

[wincowgerDEV]

Thanks Steven! I'll reach out to them.

…

On Thu, Nov 10, 2022, 5:26 AM Steven Hollingsworth ***@***.***> wrote: @wincowgerDEV <https://github.com/wincowgerDEV> can you have your friend Re-test to confirm the docs and build work correctly? — Reply to this email directly, view it on GitHub <#85 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGMUJU5BUBKDQF4ANSUP2ITWHR2QLANCNFSM6AAAAAAROGAS3E> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[wincowgerDEV]

Haven't heard back from my friend so was trying to dive into this myself but then realized that we haven't incorporated his previous comments yet: #85 (comment) Will make a PR for them now.

[shollingsworth]

Haven't heard back from my friend so was trying to dive into this myself but then realized that we haven't incorporated his previous comments yet: #85 (comment) Will make a PR for them now.

If you look at the diff, I think I did, unless I missed something.

[wincowgerDEV]

Will take a look deeper, I was looking for commits to the local deployment md file.

…

On Fri, Nov 18, 2022, 7:47 PM Steven Hollingsworth ***@***.***> wrote: Haven't heard back from my friend so was trying to dive into this myself but then realized that we haven't incorporated his previous comments yet: #85 (comment) <#85 (comment)> Will make a PR for them now. If you look at the diff, I think I did, unless I missed something. — Reply to this email directly, view it on GitHub <#85 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGMUJU5VW6V5VMJ2T4ULVGDWI7FK3ANCNFSM6AAAAAAROGAS3E> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[wincowgerDEV]

If you look at the diff, I think I did, unless I missed something.
This one says the last update was March, maybe there are some commits that haven't been pushed? https://github.com/code4sac/trash-ai/blob/production/docs/localdev.md

I am starting to work on this in the Manuscript branch now so no worries about it either way.

[shollingsworth]

@wincowgerDEV

This is part of a PR related to this issue, probably should have linked it in the first place :-P
https://github.com/code4sac/trash-ai/compare/85-testing-local-deployment-issues
^^^

[wincowgerDEV]

Currently running for Windows, this statment is unclear to me "WSL Integration on Ubuntu must be enabled in Docker options -> Resources -> WSL Integration" Is that something I would do through the Linux command prompt? It looks like docker desktop already has the integration by default so maybe we just recommend they install that?

[wincowgerDEV]

Are we sure these instructions are necessary? I think that docker-compose is now coming standard with any docker desktop installation.

See here: https://docs.docker.com/compose/install/

"docker-compose Instructions
Docker-compose file version >3.7 are supported
Windows: Take note of docker-compose installation (installing through apt may not install the correct version)
For MacOS, use docker-compose version 1.x"

[shollingsworth]

Are we sure these instructions are necessary? I think that docker-compose is now coming standard with any docker desktop installation.

See here: https://docs.docker.com/compose/install/

"docker-compose Instructions Docker-compose file version >3.7 are supported Windows: Take note of docker-compose installation (installing through apt may not install the correct version) For MacOS, use docker-compose version 1.x"

Some folks may not be using docker desktop. Maybe just recommend docker desktop, and we can remove that part.

[shollingsworth]

Currently running for Windows, this statment is unclear to me "WSL Integration on Ubuntu must be enabled in Docker options -> Resources -> WSL Integration" Is that something I would do through the Linux command prompt? It looks like docker desktop already has the integration by default so maybe we just recommend they install that?

I think @feydan put the windows instructions together. If you're following along on Windows, I say modify it to make sense to you going through the process new.

[wincowgerDEV]

Thanks! Doing that now :)

Getting pretty close to the full deployment, currently at the make local step and got this error. Do we need to require that people login to docker? Also tried logging in but still get the same error message.

"Error response from daemon: pull access denied for trash_ai_bs, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
make[1]: *** [Makefile:5: up] Error 18
make[1]: Leaving directory '/home/wincowger/code/trash-ai/localdev'
make: *** [Makefile:2: local] Error 2"

[wincowgerDEV]

Are we sure these instructions are necessary? I think that docker-compose is now coming standard with any docker desktop installation.
See here: https://docs.docker.com/compose/install/
"docker-compose Instructions Docker-compose file version >3.7 are supported Windows: Take note of docker-compose installation (installing through apt may not install the correct version) For MacOS, use docker-compose version 1.x"

Some folks may not be using docker desktop. Maybe just recommend docker desktop, and we can remove that part.

Agreed, probably simpler for us to document.

[shollingsworth]

Thanks! Doing that now :)

Getting pretty close to the full deployment, currently at the make local step and got this error. Do we need to require that people login to docker? Also tried logging in but still get the same error message.

"Error response from daemon: pull access denied for trash_ai_bs, repository does not exist or may require 'docker login': denied: requested access to the resource is denied make[1]: *** [Makefile:5: up] Error 18 make[1]: Leaving directory '/home/wincowger/code/trash-ai/localdev' make: *** [Makefile:2: local] Error 2"

No, it actually should be building trash_ai_bs, so it doesn't have to reach out for that local image.
I'm on slack if you want to go over that realtime.

[wincowgerDEV]

No, it actually should be building trash_ai_bs, so it doesn't have to reach out for that local image. I'm on slack if you want to go over that realtime.

Sweet thanks! Logging onto slack.

[wincowgerDEV]

Thanks @shollingsworth for debugging the error with me. Was able to get a successful deployment and went through the rest of the instructions and made sure they are ready to roll. Local deployment instructions are good to go to me.