Don't bind to Message class about carnac

[RolandPheasant]

@JakeGinnivan I read your blog post about bringing Rx into this project and I agree having a mutable message passing through the stream is far from ideal and is best avoided.

I have prototyped a working solution where the message is immutable on a standalone project just so I could try out. Also I managed to reduce the amount of code required by a fair degree.

I hope you are happy for me to take ownership of the issue. If so I will try and get it done very soon.

[JakeGinnivan]

Hey @RolandPheasant

Would love to see what you are doing, I know @LeeCampbell has been working on this as well at #91

[RolandPheasant]

It is a bit radical. The concept is to create an intermediate object to handle the key press collations (as you suggested above). Then each change produces a new message which is a new object - an update which replaces the old item in the collection. This enables me to make KeysController a single line of code. I will try and get it done over the weekend then invite you to look at my branch. if you like it only then will I do a PR

[LeeCampbell]

@RolandPheasant, have you reviewed the #91 Refactor PR? It sounds like you are requesting something very similar to what I have already done. Just waiting on an approver to accept the PR (or reject with reasons!) cough cough.

[RolandPheasant]

@LeeCampbell just reviewed your code. I like it. Your solution is conceptually 80% the same as mine and I see you have been very thorough and paid excellent attention to detail. The main difference between our ideas is I used immutable intermediate objects to collate / aggregate the key presses leaving the resulting message as a simple state container with no logic.

Also in my PoC solution I added another layer which simplified the KeysController to a single line but that single line does not quite work with your solution. Anyway, before I jump in, I will wait first to see whether your changes are accepted. But whether they are or not I have enjoyed studying your solution.

[JakeGinnivan]

@RolandPheasant have merged @LeeCampbell's PR, feel free to build on that then submit another PR

[LeeCampbell]

Cheers @RolandPheasant
My intention wasn't to create a perfect solution, but to help the guys take a few steps toward more idiomatic Rx. I wanted to get that work in before Jake gives a Presentation on Rx gotchas using Carnac as an example code base.

Most changes are basically my standard old tricks : Immutable where possible, Methods with their data, intention revealing naming...and not passing IObservable<T> into methods ;-)
I am sure that there is still plenty of tweaks that can be applied!