GithubHelp home page GithubHelp logo

Fetch plugins from NuGet about pretzel HOT 6 OPEN

biohazard999 avatar biohazard999 commented on August 21, 2024
Fetch plugins from NuGet

from pretzel.

Comments (6)

laedit avatar laedit commented on August 21, 2024 1

I agree that we should not overcomplicate this, I just want to display a warning on console, nothing more :)

For runtime dependency on dotnet script I was thinking of doing that in a second part or integrate it directly in Pretzel.
Anyway, we can leave it for now :)

from pretzel.

laedit avatar laedit commented on August 21, 2024

Nice idea, that is an old dream of me 😄

But that could be dangerous, we allow anyone to download virtually any files packaged on nuget with the right tag. We need at least to display a warning.

We also need to think about a (simple) dependency system, for plugins needing ScriptCs (dotnet script in a near future).

from pretzel.

biohazard999 avatar biohazard999 commented on August 21, 2024

Nice idea, that is an old dream of me 😄

Always wanted to build something like this 😁

But that could be dangerous, we allow anyone to download virtually any files packaged on nuget with the right tag. We need at least to display a warning.

Package signing could be the solution to this. But on the other hand: we do that all the time.
But we should at least hash the packages and compare it with a base line to avoid package spoofing.

We also need to think about a (simple) dependency system, for plugins needing ScriptCs (dotnet script in a near future).

If we just follow the dependencies of the nuget packages, plugin authors could just define their dependencies in their package.

from pretzel.

laedit avatar laedit commented on August 21, 2024

Package signing could be the solution to this. But on the other hand: we do that all the time.
But we should at least hash the packages and compare it with a base line to avoid package spoofing.

That can check integrity and identity but we should signal that we haven't validate/check these plugins and cannot guaranty that they are safe.

If we just follow the dependencies of the nuget packages, plugin authors could just define their dependencies in their package.

I haven't thought of that, that could do it but since it is runtime dependency I think we will have to treat it specifically.

from pretzel.

biohazard999 avatar biohazard999 commented on August 21, 2024

That can check integrity and identity but we should signal that we haven't validate/check these plugins and cannot guaranty that they are safe.

We can check how the cake guys treat this problem.

I haven't thought of that, that could do it but since it is runtime dependency I think we will have to treat it specifically.

We could advise plugin authors to use Fody.ILMerge instead of fetching dependencies or the new AssemblyLoadContext in netcore3.0 (I'm not sure about net4 support on this).

from pretzel.

biohazard999 avatar biohazard999 commented on August 21, 2024

But I think we should not overcomplicate, throw in a prototype, check integrity and see if plugin author's will jump on :)
I have a few new plugins in mind and would love to built this feature. Of course manual plugins should work as before.

from pretzel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.