GithubHelp home page GithubHelp logo

Comments (3)

cubismic avatar cubismic commented on July 30, 2024

go get github.com/ethereum/go-ethereum/rlp will download whole source code of go-ethereum.
The codes are saved in $GOPATH/pkg/github.com/ethereum/go-ethereum.
And when I import only rlp like 5cea778#diff-b22bd1d77f068190b14a8488f1e7c21b, golang only includes rlp package while compiling.

My point is, is this really could be a problem? I think downloading only rlp folder to the $GOPATH looks odder.

from codechain-sdk-go.

majecty avatar majecty commented on July 30, 2024

Thanks for explaining how the import is working.
Although other parts of Go Ethereum code is not compiled, downloading a huge code base that is not used is a problem.

from codechain-sdk-go.

majecty avatar majecty commented on July 30, 2024

@gurrpi You can try this issue.
We don't know how the Golang import is working.
So we are not confident that using Go-Ethereum's rlp package is good or bad.
IMO importing a small package in a big repository is not a recommended practice. Because a user that using CodeChain Go SDK may download the big repository to use the library.

Do you know the Golang users' convention about using a small package in a big repository?

from codechain-sdk-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.