Comments (3)
go get github.com/ethereum/go-ethereum/rlp
will download whole source code of go-ethereum.
The codes are saved in $GOPATH/pkg/github.com/ethereum/go-ethereum
.
And when I import only rlp
like 5cea778#diff-b22bd1d77f068190b14a8488f1e7c21b, golang only includes rlp
package while compiling.
My point is, is this really could be a problem? I think downloading only rlp folder to the $GOPATH
looks odder.
from codechain-sdk-go.
Thanks for explaining how the import is working.
Although other parts of Go Ethereum code is not compiled, downloading a huge code base that is not used is a problem.
from codechain-sdk-go.
@gurrpi You can try this issue.
We don't know how the Golang import is working.
So we are not confident that using Go-Ethereum's rlp package is good or bad.
IMO importing a small package in a big repository is not a recommended practice. Because a user that using CodeChain Go SDK may download the big repository to use the library.
Do you know the Golang users' convention about using a small package in a big repository?
from codechain-sdk-go.
Related Issues (20)
- Update README
- Implement large integers
- Implement crypto package HOT 2
- go test fails with unexpected end of JSON input
- Parsing error while `go get -u codechain-rpc-go` HOT 4
- Run lint using Github Actions HOT 1
- Change strings to []byte HOT 3
- Transactions in Block do not parse properly
- Test serialize/deserialize code
- Implement SDK core
- Make rpc directory
- Implementations left to Release alpha version. HOT 2
- Move some tests to example HOT 2
- Use shorter alias for package names HOT 2
- Hold pointer value if the object is nullable
- Use custom JSON marshal instead of object duplication HOT 2
- Update golang version to 1.13
- Handle RPC Error properly
- Replace hard-coded json tags to customized-marshaller
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codechain-sdk-go.