Issues with execsync prevent codecov from installing correctly about codecov-node

[isaacs]

I strongly recommend removing execSync.

Would you accept a PR that refactored it out?

[isaacs]

I ask because, now that node-tap uses this module as a dependency for sending coverage to codecov, it's causing a lot of test failures on CI systems, and it appears to me to be a very straightforward refactoring that I'd be happy to help with.

The explicit purpose of this module is to be a part of a CI workflow, so using a dep that fails to build reliably on containers seems like a pretty significant problem. If synchronous exec'ing is a must-have, then I'll have to switch back to the codecov.io module, which appears to be less well supported.

[eddiemoore]

Version 2 has been released. execsync has been removed. Should fix all issues.

[meeDamian]

+1

Fails to install on travis for node < 5

[deepsweet]

+1 here, this execsync is a pita for CI like Travis or AppVeyor.

[stevepeak]

Do you have suggestions on how to fix this? Maybe remove execsync all-together...

[StephanBijzitter]

Looking briefly through the usage of execSync, it does seem like it can easily be refactored by someone who knows how to translate the command-line magic properly. I do believe this would indeed be the cleanest solution.

[stevepeak]

@isaacs Would you accept a PR that refactored it out?

I would. As you can see there are some file-network detection that needs to occur. Would that be possible through the removal of execSync?

[VanDalkvist]

Can I ask, do you still working on it? I tried to use Codecov for my node project but I couldn't because of this issue. It seems that codecov-node is not under development anymore

[Crevil]

There sure is not a lot going on here. I created #12 some time ago fixing some of the issues with execSync, but no response.

[antonmedv]

Still not working on travis-ci

[akshayrawat]

Same problem with CircleCI.

[eddiemoore]

@Elfet @akshayrawat What version of node are you using?

[akshayrawat]

@eddiemoore node v5.0.0