AbusedClient::__doRequest Argument #5 ($oneWay) type error about laravel-soap

[bastien-phi]

I'm having the same issue here.

Under php 8.0, $oneWay is a boolean in CodeDredd\Soap\Driver\ExtSoap\AbusedClient::__doRequest (\SoapClient::__doRequest was changed https://www.php.net/manual/en/soapclient.dorequest)

Phpro\SoapClient\Soap\HttpBinding\SoapRequest expects an interger for $oneWay

As made in Phpro\SoapClient\Soap\Driver\ExtSoap\AbusedClient, CodeDredd\AbusedClient should create a SoapRequest with $this->storedRequest = new SoapRequest($request, $location, $action, $version, (int) $oneWay);

I fixed the issue locally with this simple cast.

I'll try to make a PR for this next week but feel free to do it if you want !

[bastien-phi]

Thanks for the fix and the release ! 😀

[brianfy1]

Thank you for the hint about the version.
Switching (back) to php v7.4.14 solved it apparently.

[brianfy1]

Thanks as well from my side!

[CodeDredd]

Hey, sorry for the late answer. I tried it out and couldn't reproduce the error. Which php version are you using?

[brianfy1]

Running php v8.0.1, using Laravel Homestead as my dev environment.

vagrant@box:~/code$ php -v
Xdebug: [Config] The setting 'xdebug.remote_connect_back' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_connect_back (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.remote_enable' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_enable (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.remote_log' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_log (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
Xdebug: [Config] The setting 'xdebug.remote_port' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_port (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)
PHP 8.0.1 (cli) (built: Jan 13 2021 08:22:35) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.1, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.1, Copyright (c), by Zend Technologies
    with Xdebug v3.0.2, Copyright (c) 2002-2021, by Derick Rethans
vagrant@box:~/code$

Using the latest hometead (stable) version

$ vagrant box update
==> box: Checking for updates to 'laravel/homestead'
    box: Latest installed version: 11.0.0
    box: Version constraints: >= 11.0.0, < 12.0.0
    box: Provider: virtualbox
==> box: Box 'laravel/homestead' (v11.0.0) is running the latest version.

[CodeDredd]

Your right. The cast does the trick. Phpro does it the same way. Thanks. Making an PR.