bad identation about codemirror-v1

[marijnh]

The JavaScript parser doesn't do automatic semicolon insertion, and won't properly indent code with semicolons missing.

[iliakan]

This seems strange, because from the language point of view missing semicolons is ok, even for ECMAScript 5. If javascript standard-makers allow missing semicolon, why codemirror doesn't handle it...

[marijnh]

Feel free to implement this.

[iliakan]

Does that seem difficult?

[marijnh]

It's not easy, semicolon insertion is specified to happen on a parse error, and parse errors are not well-defined in CodeMirror's JavaScript parser---it typically just skips tokens it doesn't recognize.

[iliakan]

I tried to switch to "shift" indentation with tab and sighed with relief, but that didn't help.

When I type "var a" and press enter, new line is indented the wrong way. Is there any way to fix it somehow?

I spent quite a lot of time making codemirror play really well with my site, is there anything I can do besides rewriting tokenizer ?

[marijnh]

You do realize that if you've only typed 'var a', there is no way for the editor to know whether the next line will continue with '= 10' or with 'var b ...', right?

Apart from getting used to inserting proper semicolons, you could try commenting out the 'this.indentAtCursor()' line under the '// enter' case in the keydown handler. If that suits your need, I can make it an option.

[marijnh]

This may be useful here: I just added an enterMode option, that you can set to "flat" or "keep" to override the way new lines are indented. See the manual for details.

[iliakan]

Thanks, I'll give it a roll right now.

[iliakan]

BTW, I gave this issue a thought and decided to put semicolons for now, because indentation is really nice thing. Just disabling it does not make editor look cool enough ;)

[iliakan]

Unfortunately, there is still a problem.
E.g.

function User() {
   this.setName = function(name) {
      this.name = name;
   }
}

This syntax is ok. But codemirror requires one more ; after function. It's just too much to be sane and convinient ;(

[marijnh]

An assignment is a regular statement requiring a semicolon. Since CodeMirror does not do automatic semicolon insertion, it does not currently handle what you have. Though if you upgrade to the development snapshot, I guess (though I am not sure) that it will be handled correctly.

[iliakan]

I updated to lates git. Please check this screenshot, it tells what I mean: http://img251.imageshack.us/img251/2503/ss20100826224040.png

[marijnh]

Yes, I see. It will now indent lines after this one correctly, but still mess up at the semicolon insertion point. There is no easy way to handle this. If you need proper semicolon insertion, you'll have to implement it yourself.

[iliakan]

Do I get it right that the only way to edit:

var func = function() {
...
}
...

without indentation problems is disabling auto-indent ?

[marijnh]

Correct.