GithubHelp home page GithubHelp logo

Comments (4)

marijnh avatar marijnh commented on May 27, 2024

window.getSelection is built into the browser. I'm not seeing this error. Which version of Opera are you using, and which CodeMirror page are you opening?

from codemirror-v1.

heydojo avatar heydojo commented on May 27, 2024

Oops, sorry.
I was actually trying to do this :
http://heydojo.co.cc/ckeditor-codemirror/index.html
and it is my fault. I am trying to do too much.

I use the latest snapshot of Opera Linux 10.70 from :
http://my.opera.com/desktopteam/blog/
(10.60 isn't as good.)

I think the problem I am having is that maybe I am trying to destroy and recreate a code mirror instance in a dirty way because in the demo linked above, I get two errors, one when the toggle toolbar button is clicked and the same when switching to and from source mode.

Uncaught exception: TypeError: 'b.getSelection' is not a function
Error thrown at line 12, column 946 in (b) in http://heydojo.co.cc/ckeditor-codemirror/ckeditor/plugins/codemirror/js/select.js:
var c=b.getSelection();
called from line 43, column 288 in () in http://heydojo.co.cc/ckeditor-codemirror/ckeditor/plugins/codemirror/js/editor.js:
select.markSelection(b.win);

So do you have any recommendations on how to destroy the CodeMirror instance cleanly straight after using the getCode() function?
I've read through the manual and it doesn't look like there is such a function.

Thanks,
Tony

from codemirror-v1.

marijnh avatar marijnh commented on May 27, 2024

Hi Tony,

I have pushed a fix to the CodeMirror git repository that should fix this. The problem was that a timeout was firing (for the continuousScanning option), which tried to work with the frame, after the frame had been removed from the document. This largely worked, except that, apparently, the window.getSelection function vanishes when a frame is no longer in the document.

Best,
Marijn

from codemirror-v1.

heydojo avatar heydojo commented on May 27, 2024

Wow!
Much appreciated.
Thanks for the fix to your awesome editor.
I'll update the demo ASAP.

Cheers!
Tony

from codemirror-v1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.