onChange doesn't work as expected about codemirror5

[marijnh]

Hello Matt,

I setup this handler in an instance of CodeMirror 2 and it's executed only on component creation time, on setValue() and when 'delete' key is pressed. I would expect onChange to be executed on every keystroke that results in editor's content change.

This would be a bug. However, it is not something that I can
reproduce. It seems to work fine for me. Please verify that you're
setting up your handler correctly and not, for example, calling it
when you're passing it to CodeMirror, instead of passing the function
value.

Best,
Marijn

[edmellum]

I'm having this problem too and can't even see any mention of onChange in the source. I'm probably doing something wrong, but seeing the actual code that's handling this would probably help. Could you point me in the right direction?

[marijnh]

In the current version, line 1221 in lib/codemirror.js calls the
onChange handler.

[mattpap]

I was a little too fast with reporting this issue, because onChange works with my webapp when the editor is attached to the top-level element (document > div), but fails (as described previously) when the editor is attached to an ExtJS window. I embed multiple editors in a single window, so I thought that they might interfere with each other, but this is not the case. For now I'm not sure which part of my webapp make the editor fail, but when I will find out, I will post my findings here.

[edmellum]

Ah, I was actually browsing the old CodeMirror repo, not the CodeMirror2 one, so now I can see everything clearly.

So what I figured out is that the onChange function I supplied is called once right away before the editor is properly initialized for some reason and therefore does not receive the editor in its argument. A simple if check fixed it, but I've never experienced something like it with a Javascript library before.

[mattpap]

It seems that recent commit (65f257b) fixed this issue for me, so I'm closing it as not valid anymore.