GithubHelp home page GithubHelp logo

Comments (5)

marijnh avatar marijnh commented on August 15, 2024 1

Does patch codemirror/view@1ecb5f1 look like it would work for you?

from dev.

krassowski avatar krassowski commented on August 15, 2024

I am checking if the new docViewUpdate could help here...

from dev.

krassowski avatar krassowski commented on August 15, 2024

No, docViewUpdate does not get called on cursor movement.

I can still use update() but this involves a lot of filtering down of undesirable updates. The problem when used from TypeScript is that view.viewState.scrollTarget is not exposed because viewState is marked as internal. If we could probe whether scrollTarget is defined I can handle this in update listener:

My current solution comes down to:

ViewPlugin.define((view) => {
  return {
    update: () => {
      // @ts-ignore
      const scrollTarget = view.viewState.scrollTarget;
      if (scrollTarget) {
        scrollVirtualizedListToEditor(scrollTarget);
      }
    }
  };
})

or equivalently:

EditorView.updateListener.of((viewUpdate) => {
  // @ts-ignore
  const scrollTarget = viewUpdate.view.viewState.scrollTarget;
  if (scrollTarget) {
      scrollVirtualizedListToEditor(scrollTarget);
  }
})

Would you consider exposing scrollTarget via getter on EditorView? If not, what about having a new scroll entry point like below?

ViewPlugin.define((view) => {
  return {
    scroll: (scrollTarget: ScrollTarget) => {
      scrollVirtualizedListToEditor(scrollTarget);
    }
  };
})

from dev.

krassowski avatar krassowski commented on August 15, 2024

Yes, this looks like it should do it, thank you!

from dev.

marijnh avatar marijnh commented on August 15, 2024

Released as part of @codemirror/view 6.26.0

from dev.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.