GithubHelp home page GithubHelp logo

Comments (4)

lijie1129 avatar lijie1129 commented on May 18, 2024 1

hi, @SneakiBrina

Thank you for reporting this issue. 🤝

To fix this issue, I think we need to get the width value of the inline toolbar.

The current rendering process of inline toolbar is as follows:

  1. Calculate the positioning information of the inline toolbar
  2. Display inline toolbar (transparency adjusted from 0 to 1)
  3. Fill the inline toolbar with inline action buttons, such as bold, italic...

https://github.com/codex-team/editor.js/blob/next/src/components/modules/toolbar/inline.ts#L155-L156

https://github.com/codex-team/editor.js/blob/next/src/components/modules/toolbar/inline.ts#L167

Since the third step will affect the width value of the inline toolbar, we need to calculate the positioning information after the third step (the issue of overflow on the right side is handled in the logic of calculating the positioning information)

hi, @SneakiBrina

I saw the PR you submitted. It seems that your solution is correct. 👍

Please ignore what I said above.

from editor.js.

lijie1129 avatar lijie1129 commented on May 18, 2024

hi, @SneakiBrina

Thank you for reporting this issue. 🤝

To fix this issue, I think we need to get the width value of the inline toolbar.

The current rendering process of inline toolbar is as follows:

  1. Calculate the positioning information of the inline toolbar
  2. Display inline toolbar (transparency adjusted from 0 to 1)
  3. Fill the inline toolbar with inline action buttons, such as bold, italic...

https://github.com/codex-team/editor.js/blob/next/src/components/modules/toolbar/inline.ts#L155-L156

https://github.com/codex-team/editor.js/blob/next/src/components/modules/toolbar/inline.ts#L167

Since the third step will affect the width value of the inline toolbar, we need to calculate the positioning information after the third step (the issue of overflow on the right side is handled in the logic of calculating the positioning information)

from editor.js.

MussaratAziz avatar MussaratAziz commented on May 18, 2024

@SneakiBrina any way to change the icons on InlineToolbar?

from editor.js.

neSpecc avatar neSpecc commented on May 18, 2024

Resolved by #2550

from editor.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.