Comments (4)
hi, @SneakiBrina
Thank you for reporting this issue. 🤝
To fix this issue, I think we need to get the width value of the inline toolbar.
The current rendering process of inline toolbar is as follows:
- Calculate the positioning information of the inline toolbar
- Display inline toolbar (transparency adjusted from 0 to 1)
- Fill the inline toolbar with inline action buttons, such as bold, italic...
https://github.com/codex-team/editor.js/blob/next/src/components/modules/toolbar/inline.ts#L155-L156
https://github.com/codex-team/editor.js/blob/next/src/components/modules/toolbar/inline.ts#L167
Since the third step will affect the width value of the inline toolbar, we need to calculate the positioning information after the third step (the issue of overflow on the right side is handled in the logic of calculating the positioning information)
hi, @SneakiBrina
I saw the PR you submitted. It seems that your solution is correct. 👍
Please ignore what I said above.
from editor.js.
hi, @SneakiBrina
Thank you for reporting this issue. 🤝
To fix this issue, I think we need to get the width value of the inline toolbar.
The current rendering process of inline toolbar is as follows:
- Calculate the positioning information of the inline toolbar
- Display inline toolbar (transparency adjusted from 0 to 1)
- Fill the inline toolbar with inline action buttons, such as bold, italic...
https://github.com/codex-team/editor.js/blob/next/src/components/modules/toolbar/inline.ts#L155-L156
https://github.com/codex-team/editor.js/blob/next/src/components/modules/toolbar/inline.ts#L167
Since the third step will affect the width value of the inline toolbar, we need to calculate the positioning information after the third step (the issue of overflow on the right side is handled in the logic of calculating the positioning information)
from editor.js.
@SneakiBrina any way to change the icons on InlineToolbar?
from editor.js.
Resolved by #2550
from editor.js.
Related Issues (20)
- Simplifying Tool Icon Customization
- The simple-image doesn't work HOT 2
- Convert the paragraph to list automatically when the user types 1. or -
- Header elements aren't aligned with the toolbar actions
- TypeError: Cannot read properties of undefined (reading 'length') HOT 1
- Support for <font> tag inside the paragraph block HOT 1
- Duplicate copied links in a nested list
- Issue when upgrading `@editorjs/inline-code` to `1.5.0`
- How do I know if a block was created by a pasting action or by a user's manual click? HOT 1
- Improve alignment on the left side of the editor HOT 1
- onChange event is triggered immediately on initialization HOT 12
- Strange behavior when accessing state value in onChange
- TypeError: Cannot read properties of undefined (reading 'isInternal') HOT 1
- Styling using only utility classes (like Tailwind)
- TypeError: Spread syntac requires ...iterable[Symbol.iterator] to be a function HOT 1
- Feature Request : Inline Block Tool HOT 1
- Hello, How to create a top toolbar? Thanks.
- renderFromHTML is not awaiting clear() method HOT 1
- Unable to Trigger onChange Event for Next Line in EditorJS Paragraph in React JS
- rawHTML code field isnt rendering the html in the field HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from editor.js.