Zip download is missing files and won't build about imagehash

[coenm]

You are right. It should be possible to compile ImageHash from a Github zip download, but it isn't.

Glad to hear that you found a workaround by cloning the repository (which includes the .git folder).

I use GitVersion to determine the version, and to stamp the output dll and package with that version. GitVersion uses git (i.e. the .git folder) to calculate the version. That's the reason it is not working as expected.

At this moment, I'm not going to fix this because to support GitHub zip downloads, I should replace GitVersion with something else, try to make Github include the .git folder or maybe something else. I don't have the time for that right now.

If you have a fix, you can create a Pull Request.

[daviddennisei]

I have a workaround, and am not conversant enough with ImageHash or git (I used mercurial for my repos) to attempt a fix. My opinion is that ImageHash should have its own standalone version scheme, independent of github. - Thanks Best regards, David Ei Email: <mailto:[email protected]> [email protected] Home: [phone] Cell: [phone] From: Coen van den Munckhof [mailto:[email protected]] Sent: Wednesday, November 11, 2020 3:07 AM To: coenm/ImageHash <[email protected]> Cc: daviddennisei <[email protected]>; Author <[email protected]> Subject: Re: [coenm/ImageHash] Zip download is missing files and won't build (#30) You are right. It should be possible to compile ImageHash from a Github zip download, but it isn't. Glad to hear that you found a workaround by cloning the repository (which includes the .git folder). I use GitVersion to determine the version, and to stamp the output dll and package with that version. GitVersion uses git (i.e. the .git folder) to calculate the version. That's the reason it is not working as expected. At this moment, I'm not going to fix this because to support GitHub zip downloads, I should replace GitVersion with something else, try to make Github include the .git folder or maybe something else. I don't have the time for that right now. If you have a fix, you can create a Pull Request. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#30 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGAE4EEZZKMBRNFPVINAIK3SPJAZFANCNFSM4TRI22PQ> . <https://github.com/notifications/beacon/AGAE4EAJASHAUGOYI6G4QA3SPJAZFA5CNFSM4TRI22P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFM5MKSA.gif>