[Resolved] [v2] Whitelist Security Issue about red-discordbot

[Asute]

Have you tried whitelisting using the person's ID instead of their name? Usually name is not recommended for that reason.

[NotGray]

Yup. It wouldn't add properly.

On Mon, Feb 8, 2016 at 10:17 PM, Asute [email protected] wrote:

Have you tried whitelisting using the person's ID instead of their name?
Usually name is not recommended for that reason.

—
Reply to this email directly or view it on GitHub
#48 (comment)
.

[Twentysix26]

I don't know where you got the impression that the whitelist works by name. It doesn't.

[NotGray]

This is for the v2 bot

When you type: !help whitelist

When using: !whitelist add
It doesn't register it. But it does register: !whitelist add @ or
!whitelist add

On Tue, Feb 9, 2016 at 12:25 PM, Twentysix [email protected] wrote:

I don't know where you got the impression that the whitelist works by
name. It doesn't.

—
Reply to this email directly or view it on GitHub
#48 (comment)
.

[Twentysix26]

What would be the advantage of directly adding user ids? Chances are that the user you want to add is already in your server, might as well add directly its name.

I'm not sure you get it, so I'm explaining this again. Whitelist is based on IDs. When you add an user, its ID get added in the list. Copying the user's name after that is useless, as the ID would still be different

[NotGray]

What if there are multiple users with the same name at the time of
whitelist?
Which user ID would it decide to whitelist then?

Sorry if I'm coming off as an ass, I'm not trying to be as I'm a fan of
your work but just am trying to understand this bit is all

On Tue, Feb 9, 2016 at 4:42 PM, Twentysix [email protected] wrote:

What would be the advantage of directly adding user ids? Chances are that
the user you want to add is already in your server, might as well add
directly its name.

I'm not sure you get it, so I'm explaining this again. Whitelist is based
on IDs. When you add an user, its ID get added in the list. Copying the
user's name after that is useless, as the ID would still be different

—
Reply to this email directly or view it on GitHub
#48 (comment)
.

[Asute]

You @ mention the person you want to whitelist and the bot will choose that person mentioned.

[NotGray]

What if there are multiple users with the same username on your server at the time?
Which one does the bot decide to add?

[Asute]

Like I said, you can specifically choose who to @ mention.

[NotGray]

My apologies, was a client-side error on my end.
Apparently the @ wasn't showing any results at the time.
A client restart fixed this error.

Sorry for the confusion and waste of time :(

On Wed, Feb 10, 2016 at 6:10 AM, Asute [email protected] wrote:

Like I said, you can specifically choose who to @ mention.

—
Reply to this email directly or view it on GitHub
#48 (comment)
.