GithubHelp home page GithubHelp logo

Comments (7)

Thiana avatar Thiana commented on July 21, 2024

williewillus/Botania/issues/45

from hammerz.

ColinGBos avatar ColinGBos commented on July 21, 2024

So is this a crash?

from hammerz.

williewillus avatar williewillus commented on July 21, 2024

yeah, the eventhandler NPE's

from hammerz.

williewillus avatar williewillus commented on July 21, 2024

Not sure if this is our fault, you say that you can reproduce by using a manasteel pickaxe, except that our eventhandler doesn't apply at all unless the tool is an elementium, terrasteel, or glass pickaxe

Are you sure you can only do it with botania installed?

from hammerz.

ColinGBos avatar ColinGBos commented on July 21, 2024

I would say this isn't Botania's fault at all, I'll add yet more null checks and see what's up.

from hammerz.

Thiana avatar Thiana commented on July 21, 2024

@williewillus Positive. With either mod on its own everything works perfectly. Add them together and no drops. Thats why I reported on both repos since it seemed likely to be some sort of interaction in the handlers.

Edit: And it seems to be any tool that isnt a hammer. ie, axes/shovels/pickaxes both vanilla and botania.

from hammerz.

ColinGBos avatar ColinGBos commented on July 21, 2024

Strange that this hasn't caused an issue before. Either way, I changed how I handle stacks where I'm not sure that the item is a Hammer so this type of thing shouldn't pop up anymore.
Will see if I can push the release tonight (if I can log into curse from where I am >.>)

from hammerz.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.