GithubHelp home page GithubHelp logo

[1.8.9] Materials about hammerz HOT 11 CLOSED

colingbos avatar colingbos commented on August 23, 2024
[1.8.9] Materials

from hammerz.

Comments (11)

ColinGBos avatar ColinGBos commented on August 23, 2024

Sorry for taking a while to comment, I was away for the day.
Because the recipes for a standard hammer are oredictionary recipes, they will be enabled if there is an instance of "blockMaterial" where material is the name (eg blockCopper). Many mods are really good at registering itemstacks for their ingots, but not as many do it for their blocks (including Botania and Thaumcraft), There are mods that add oredictionary entries to the tooltips of blocks, can you confirm that the storage blocks from Fun Ores are registered?
As of the latest 1.8.9 version, repairing and enchanting should both be fully functional although I will need to have a look at the hammerz not breaking when they run out of durability.

Thanks for the report!

from hammerz.

SwordKorn20 avatar SwordKorn20 commented on August 23, 2024

Firstly thanks for replying! Don't worry about being away.

I have since tested that anvils can repair them (as in Magnanimous Tools) and it seems to be working fine. Due to my sheer lack of finding diamonds in my Survival world, I am yet to test enchanting :(

I have had a look at the blocks used by Silent in Fun Ores and it appears he's registering them as MetalBlock# and AlloyBlock#. Copper is registered as MetalBlock0 and Bronze as AlloyBlock0.

This explains why they aren't registering as usable materials. I think Silent needs to take a sit down and do some oreDictionary work for his blocks. His ingots are fine.

from hammerz.

ColinGBos avatar ColinGBos commented on August 23, 2024

I actually remembered that there is a config option in this mod for adding ore-dictionary entries to itemstacks, so if you come across a similar issue in the future you can use that. Silent (and all mod authors) should add entries for item stacks of their metal storage blocks just as forge does for vanilla, unfortunately fewer people depend on them to be registered than ingots, dusts or ores.

from hammerz.

SwordKorn20 avatar SwordKorn20 commented on August 23, 2024

Call me either blind or stupid, or both; but I guess you mean your config file.

Is it in the enabled oreDictionary hammers?

from hammerz.

ColinGBos avatar ColinGBos commented on August 23, 2024

It's in the random options in the config file, it doesn't add any content or change which hammers load, it just adds whatever strings an itemstack may be registered in the oredictionary to its tooltip. It's handy for seeing something like if a metal storage block is registered, if it isn't, it won't have an entry. All of the ingots and dusts have valid entries but the blocks don't.

from hammerz.

SwordKorn20 avatar SwordKorn20 commented on August 23, 2024

Ah that's useful! I know it isn't my mod, but I'd love to decompile Fun Ores and change the blocks to instances of blockMaterial.

I may ask Silent to look at that as a suggestion. Thank you very much for your help!

from hammerz.

ColinGBos avatar ColinGBos commented on August 23, 2024

It is important to point out that the oredictionary is completely separate from block or item instantiation. It's a registry added by forge which works on an opt-in basis which is why many authors don't bother. Anyone can find an itemstack and register it, regardless of if its their item or not, I do this with thaumcraft and botania blocks because they don't themselves and could do it for others but it isn't the best practice to do it for others... :P

from hammerz.

SwordKorn20 avatar SwordKorn20 commented on August 23, 2024

Well even if he simply adds it as a configuration option, it would help. As of the time of writing, his mod is one of the few adding these metals and alloys to the game.

from hammerz.

ColinGBos avatar ColinGBos commented on August 23, 2024

My latest repository may be of interest to you, its set for release hopefully at some point this week. But definitely encourage people to make full proper use of the oredictionary if you ever notice that they aren't.

from hammerz.

SwordKorn20 avatar SwordKorn20 commented on August 23, 2024

Well I'm an aspiring mod developer and I feel that use of the OreDictionary should be mandatory.

Not that I'm saying in any way that his way is wrong, but it makes mod integration a lot easier.

from hammerz.

SwordKorn20 avatar SwordKorn20 commented on August 23, 2024

I have to admit though; this has made me want to work on a ore mod with better integration for 1.8.9

from hammerz.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.