GithubHelp home page GithubHelp logo

Comments (14)

colinmutter avatar colinmutter commented on July 20, 2024

Yes, I'm working on testing their new code.

from google-api-adwords-php.

Jakobud avatar Jakobud commented on July 20, 2024

Cool thanks

from google-api-adwords-php.

Jakobud avatar Jakobud commented on July 20, 2024

Have you considered just working with the official release and doing a big pull request to help convert their code to be composer friendly instead of converting everything yourself after they do a release?

googleads/googleads-php-lib#12

from google-api-adwords-php.

onema avatar onema commented on July 20, 2024

Any ETA for the latest update 😃 ?
Thank you for maintaining this repo !!

from google-api-adwords-php.

onema avatar onema commented on July 20, 2024

bump

from google-api-adwords-php.

Jakobud avatar Jakobud commented on July 20, 2024

Like I said, you should really just work with the official API repository and help them convert their code to be Composer compatible so that you wouldn't have to maintain this.

from google-api-adwords-php.

colinmutter avatar colinmutter commented on July 20, 2024

I definitely agree now that they've moved to github and seem to be more flexible on the matter. In the interim I'll try to get a new update soon.

from google-api-adwords-php.

colinmutter avatar colinmutter commented on July 20, 2024

Thanks to @onema for the issue at googleads/googleads-php-lib#30 we might have this migrated over soon to the official repo. Sorry all for not being able to update this as often as needed.

from google-api-adwords-php.

onema avatar onema commented on July 20, 2024

@Jakobud This library has been around for over a year and there have been over 20k installs. Is nice that Google moved their libraries over to GitHub but I'm not sure how good it would be for the many projects that depend on this one to do a switch cold turkey.
I would love to switch in favor of the googleads-php-lib, and I will as soon as autoloader support is there, but in the mean time it would be nice to see this library supported at least for one more version before it gets deprecated.
@colinmutter any thoughts?

from google-api-adwords-php.

Jakobud avatar Jakobud commented on July 20, 2024

I understand what you are saying. It sounds like there is probably still significant work to do to update this to the latest version though.

I for one would love to see this library converted to really be a true PSR-0 compatible library. Right now the official library does all sorts of "require_once" calls and stuff. Not great. Makes it more difficult to add to a project since there are so many dependency paths.

Ultimately it's up to @colinmutter. It's his project and he can do whatever he wants. Moving everything over to the official repo was just a suggestion, as they have expressed interest themselves in making the library full autoloader-friendly and Composer-friendly.

from google-api-adwords-php.

onema avatar onema commented on July 20, 2024

@Jakobud I agree with your suggestion, putting some work to get the official repository up to date with composer, modern PHP practices and interoperability is good.

There are GH Issues requesting PSR-0/4 support and autoloader support!

The last adwords API update has some big additions that will be nice to have without having to make a library switch or a re-write of the my code.

In any case, I am nothing but grateful for the help this repo has provided! 😃

from google-api-adwords-php.

jamesmills avatar jamesmills commented on July 20, 2024

"In any case, I am nothing but grateful for the help this repo has provided!" +1

from google-api-adwords-php.

colinmutter avatar colinmutter commented on July 20, 2024

You should be able to update to the 5.2.* branch ("unstable"). If someone else can also confirm that it's working for them that would be helpful.

5.2* branch
https://github.com/colinmutter/google-api-adwords-php/tree/unstable

composer require cmutter/google-adwords-api:dev-unstable

from google-api-adwords-php.

colinmutter avatar colinmutter commented on July 20, 2024

Closed by #9

from google-api-adwords-php.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.