Rails 4.0 support? about delayed_job_active_record

[agrobbin]

👍 It'd be great to get this dependency loosened to allow for 4.0.

[sferik]

Has anyone tested this?

[agrobbin]

Looks like collectiveidea/delayed_job#464 would also need to be merged in. When running the suite locally with Ruby 2.0.0-p0, ActiveRecord 4.0.0.beta1, ActiveSupport 4.0.0.beta1, it does fail now that attr_accessible has been extracted into a separate gem, along with a bunch of warnings.

DEPRECATION WARNING: ActiveSupport::BasicObject is deprecated! Use ActiveSupport::ProxyObject instead. (called from <module:Delayed> at /Users/alex/Rails/gems/delayed_job/lib/delayed/message_sending.rb:5)
DEPRECATION WARNING: Calling #default_scope without a block is deprecated. For example instead of `default_scope where(color: 'red')`, please use `default_scope { where(color: 'red') }`. (Alternatively you can just redefine self.default_scope.). (called from <class:Story> at /Users/alex/Rails/gems/delayed_job_active_record/spec/spec_helper.rb:47)
DEPRECATION WARNING: Model.scoped is deprecated. Please use Model.all instead. (called from reserve at /Users/alex/Rails/gems/delayed_job_active_record/lib/delayed/backend/active_record.rb:48)
DEPRECATION WARNING: Model.scoped is deprecated. Please use Model.all instead. (called from reserve at /Users/alex/Rails/gems/delayed_job_active_record/lib/delayed/backend/active_record.rb:49)
DEPRECATION WARNING: Model.scoped is deprecated. Please use Model.all instead. (called from reserve at /Users/alex/Rails/gems/delayed_job_active_record/lib/delayed/backend/active_record.rb:50)
DEPRECATION WARNING: Model.scoped is deprecated. Please use Model.all instead. (called from reserve at /Users/alex/Rails/gems/delayed_job_active_record/lib/delayed/backend/active_record.rb:51)
DEPRECATION WARNING: Model.scoped is deprecated. Please use Model.all instead. (called from reserve at /Users/alex/Rails/gems/delayed_job_active_record/lib/delayed/backend/active_record.rb:52)
DEPRECATION WARNING: Relation#update_all with conditions is deprecated. Please use Item.where(color: 'red').update_all(...) rather than Item.update_all(..., color: 'red'). (called from clear_locks! at /Users/alex/Rails/gems/delayed_job_active_record/lib/delayed/backend/active_record.rb:40)
An error occurred in an after hook
  RuntimeError: `attr_accessible` is extracted out of Rails into a gem. Please use new recommended protection model for params(strong_parameters) or add `protected_attributes` to your Gemfile to use old one.
  occurred at /Users/alex/.rvm/gems/ruby-2.0.0-p0@delayed_job_active_record/gems/activemodel-4.0.0.beta1/lib/active_model/deprecated_mass_assignment_security.rb:14:in `attr_accessible'

Sorry for jumping to the conclusion that this was ready for a simple version dependency change!

[superbilk]

+1 for making it compatible with rails 4.0.0.beta1

[sferik]

Gem version 4.0.0.beta2 should provide support for Rails 4.

[baldursson]

Trying to install 4.0.0.beta3 and get this error:
delayed_job_active_record (= 4.0.0.beta3) ruby depends on
activesupport (~> 3.0) ruby

Current version of activesupport is of course 4.0.0.

However, the beta2 seems to work fine in Rails 4.

[albus522]

You have to use the beta version of delayed_job_active_record

[baldursson]

I thought I was clear it is the latest beta (beta3) that doesn't work with Rails 4, but the previous does (beta2).

[albus522]

Something in your gemfile or lock file is doing that, not delayed_job_active_record. Do you have your gemfile requiring the beta of DJ as well?

[baldursson]

I had this line in my Gemfile:
gem 'delayed_job_active_record', '4.0.0.beta3'

And that's when I got the error above, this time I'm adding the full error:

Bundler could not find compatible versions for gem "activesupport":
In Gemfile:
  delayed_job_active_record (= 4.0.0.beta3) ruby depends on
    activesupport (~> 3.0) ruby

  clockwork (>= 0) ruby depends on
    activesupport (4.0.0)

But when I switched the line to:
gem 'delayed_job_active_record', '4.0.0.beta2'

It worked.

Any clue what's happening?

[albus522]

Do you have
gem "delayed_job", "~> 4.0.0.beta2"
in your gemfile?

[baldursson]

Nope, just the delayed_job_active_record gem.

[albus522]

You need both

[baldursson]

Alright, that did the trick. Thanks!