GithubHelp home page GithubHelp logo

Comments (7)

facelessuser avatar facelessuser commented on June 3, 2024

What hue would you suggest gray has? The reason why you get an undefined hue (none) is because the color is achromatic and has no hue.

from color.js.

star-over avatar star-over commented on June 3, 2024

I suggest use 0 instead none when color stringify. So, I expect hsl(0 0% 50.196%) but not a hsl(none 0% 50.196%)

Because converting color with none to other format is another issue:

(new Color("hsl(none 0% 50.196%)")).to("srgb").toString()
>>> 'rgb(none none none)'

but with 0 instead none it works corretly:

(new Color("hsl(0 0% 50.196%)")).to("srgb").toString()
>>> 'rgb(50.196% 50.196% 50.196%)'

from color.js.

facelessuser avatar facelessuser commented on June 3, 2024

none is now supported in the CSS spec and has been implemented in a number of browsers. Gray doesn't actually have a red (0deg) hue, but regardless of technicalities of what is more correct, I can imagine some people desiring a way to serialize without none. There was an option to do so for some amount of time, but it was removed in e28cd6a.

Below does look like a bug to me though. Undefined values should be handled before conversion, but that does not appear to be happening currently.

new Color("hsl(none 0% 50.196%)").to("srgb").toString()
>>> 'rgb(none none none)'

from color.js.

star-over avatar star-over commented on June 3, 2024

I just fixed problem for a while with a .toString().replaceAll("none", "0") after any stringify.

from color.js.

facelessuser avatar facelessuser commented on June 3, 2024

I personally think an option to allow omitting none in serialization seems reasonable, but thenone conversion issue should definitely get fixed.

from color.js.

facelessuser avatar facelessuser commented on June 3, 2024

I've created a PR (#476) to adjust the bad "none" handling across the library.

@svgeesus and @LeaVerou would need to make a decision on whether it is desired to expose conditional "none" serialization. If they decided that they wanted to move forward with this, I'd be happy to make the PR.

from color.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.