Error on navigating away from page about angular-media-player

[cristiano-belloni]

+1

[colthreepv]

I would be happy to help, but add more details to the report.. this happens in normal pages or when navigating away views? (ex: using ui-router)

in the latter case a plunkr can be made up and would be really helpful to track down the issue

[cristiano-belloni]

navigating views, I'm fairly sure the culprit is scope.$on('$destroy', player.$destroy);

[cristiano-belloni]

Sorry, my error message was different. Will open a new issue.

[cristiano-belloni]

Managed to create a plkr for this bug (which seems somehow related to #38): http://plnkr.co/edit/6Ji1TtT10JyBe8GsQutc?p=preview

How to reproduce:
Click the /bug view link, then go back to the / view. See the TypeError: Cannot read property '$$destroyed' of null message.

[cristiano-belloni]

I suspect this happens everytime on scope destruction, but it is not easily seen because most scopes don't get destroyed during the lifetime of an angular app.

[sqrter]

+1

[joe-schorn]

+1

[colthreepv]

Okey, coming back after some time to the lib, I think I am a douche.
player.$destroy was a method of the player in previous versions to clear the event listeners attached to the directive element.

I don't think it's necessary anymore, since if the element gets removed from the DOM, the event listeners attached to the DOM EL gets garbage collected.

So I assume I'll just remove the call and not try to fix it with something working.

To check if I did something wrong I'll have to profile the memory when creating/destroying multiple media player directives

Sorry, I've been experiencing this error and haven't really seen the solution in the thread. Any suggestions?