GithubHelp home page GithubHelp logo

Proposed Car Abstraction Layer about openpilot HOT 6 CLOSED

geohot avatar geohot commented on July 22, 2024 2
Proposed Car Abstraction Layer

from openpilot.

Comments (6)

TheMutley avatar TheMutley commented on July 22, 2024
  • Think about EV : braking is part regen and part hydraulic , no RPM, no gear ratio, etc..
  • Radar you can probably add angle of detection and direction of TrackID
  • Plausible to broadcast to radio with Bluetooth for any audible Sound ?
  • Might be interested in the stock LKA status and front cam information since some integration will leave it "running" ?

from openpilot.

geohot avatar geohot commented on July 22, 2024
  • Good point about EVs, the controls software doesn't really need gearRatio and RPM, so I'll remove them and replace with bool gearReverse
  • angle = atan2(yRel, dRel)
  • The NEO itself can do sound, but it's not as reliable and doesn't lower the volume when it plays.
  • We remove the stock front cam, and that's how openpilot will be supported. Soon we will have support for cars that don't have stock cams.
  • Though along these lines we should probably add support for blind spot detection on cars that have it, that way we can do automatic lane change. Will add once we find such a car.

update: Updated, reverseGear is now an error and RPM and gearRatio are removed. Controls didn't use them, and humans drive totally fine without them. Our software should treat automatic transmissions as black boxes.

from openpilot.

TheMutley avatar TheMutley commented on July 22, 2024

Thanks.

  • Could you bring us some clarifications on how the radar report it's trackIDs on the Honda/Acura? Does dRel represent the D and yRel represent the R like on this drawing :
    us07512516-20090331-d00000

  • Also , how the TrackIDs are sequenced? For example, on mine Track ID 1 is the obstacle in front of the vehicle, Track ID 2 is the obstacle in front of Track ID 1, Track ID 3 / 5 is an obstacle on the left lane , Track ID 4/6 is an obstacle on the right lane. Are they reported somewhat like this on the Honda ?

  • For the sound from the NEO, if you could do it like Waze does, at least on my car, it lower the music sound level and bring the Waze's notifications at the same level the music was. Pretty much like the alert sound does with the stock collision warning.

  • As for blind spot detection , I do have them on mine although I never looked for the CAN information. If they're supported , I will hunt the CAN data for sure!

  • One other thing you could add is the gap distance setting that some ACC has, usually 3-4 settings possible. Handy sometime to be able to change the gap.

from openpilot.

geohot avatar geohot commented on July 22, 2024

dRel is the adjacent and yRel is the opposite on the right triangle to the car. The trackIds are sequential counting up.

That works if the NEO is playing the music only. Coming soon!

Yea, let me know re: BSI.

I don't like choices, more to qualify. I also feel the really short following distances supported on some cars are dangerous, since the user doesn't have time to react if the car messes up following closely.

from openpilot.

ingenieroariel avatar ingenieroariel commented on July 22, 2024

I don't like choices, more to qualify. I also feel the really short following distances supported on some cars are dangerous, since the user doesn't have time to react if the car messes up following closely.

I agree with this thinking too. That said, with the stock Ford functionality at lower speeds cars behind me try to overtake me and then my car ends up leaving another big gap and it happens again. If it is not optional, hopefully openpilot maintains a safe distance in time units instead of meter units.

from openpilot.

geohot avatar geohot commented on July 22, 2024

It's time units, yea.

from openpilot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.