[BUG] Sentences are not accepted on the new sentence collector app for Amharic about common-voice

[moz-rotimib]

Hello, @quaja-abu thanks for flagging this issue.

Please could you send the text you tried to contribute so I can try to reproduce this issue myself? I've tried copying the text from the image but sadly I cannot.

Best regards,

Rotimi

[quaja-abu]

The sentence is: ሴኮባ ኮናቴ ጊኒ ውስጥ የሚገኝ ጁንታ ጊዜያዊ መሪ በመታመሙ ወደ ሴኔጋል ተወሰደ Which is found here line 7:- https://github.com/asmelashteka/HornMT/blob/main/data/amh.txt በሰኞ፣ ሜይ 15 2023 11:54 AM moz-rotimib ***@***.***> ላይ የሚከተለው ተጽፏል፦

…

Hello, @quaja-abu <https://github.com/quaja-abu> thanks for flagging this issue. Please could you send the text you tried to contribute so I can try to reproduce this issue myself? I've tried copying the text from the image but sadly I cannot. Best regards, Rotimi — Reply to this email directly, view it on GitHub <#4044 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN7KV3LN453REA4S2D6TVA3XGHVNZANCNFSM6AAAAAAYBKGNYM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[moz-rotimib]

Thanks for the response @quaja-abu I've tried to add the sentence myself and I get the error as you do.

I checked the network request and it seems the reason the sentence is rejected is because it contains abbreviations (check screenshot)

As an improvement to the write page, we will make the error messages clearer to users so they know what the exact validation error is. Let me know if you have any further questions.

I hope this helps.

Rotimi

[quaja-abu]

OK I see but there is no abbreviation in the sentence and I tried it with another sentence and it still didn't accept it. See the attachment. በሰኞ፣ ሜይ 15 2023 5:22 PM moz-rotimib ***@***.***> ላይ የሚከተለው ተጽፏል፦

…

Thanks for the response @quaja-abu <https://github.com/quaja-abu> I've tried to add the sentence myself and I get the error as you do. I checked the network request and it seems the reason the sentence is rejected is because it contains abbreviations (check screenshot) [image: Screenshot 2023-05-15 at 16 18 08] <https://user-images.githubusercontent.com/113194143/238377292-29a8f326-ec1b-4ad5-be16-6bb3f61536b0.png> As an improvement to the write page, we will make the error messages clearer to users so they know what the exact validation error is. Let me know if you have any further questions. I hope this helps. Rotimi — Reply to this email directly, view it on GitHub <#4044 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN7KV3MGJOJBPXSGZ56YOYDXGI3ZBANCNFSM6AAAAAAYBKGNYM> . You are receiving this because you were mensentence. Message ID: ***@***.***>

[moz-rotimib]

Hello @quaja-abu unfortunately I can't see the attachment you send via email on GitHub. Could you try to send the attachment here on GitHub when you can?

Also, it seems some of our validation rules for some languages might not be able to handle certain edge cases. If you are able to, you can take a look at the validation rules we use for Amharic abbreviations to help figure out a better way to handle abbreviations.

Best,

Rotimi

[quaja-abu]

Here is the screenshot

[quaja-abu]

The sentence I used
የእስራኤል አየር ሃይል የተቃጣበትን የሚሳኤል እና የሞርታር ጥቃት መላሽ ነው

[moz-rotimib]

I get the same error too and it is rejected because of the no abbreviations rule.

I think the abbreviation validation rule we use for Amharic needs to be updated so unfortunately some sentences might not be able to be contributed till this is fixed.

[quaja-abu]

You are right. I will try to work on that myself. I was the one that I created the rule. FYI the regex is supposed to identify Amharic words that are separated by .(dot)

[quaja-abu]

But abbreviations might also separated by back slash (/) in too Amharic. Forexample, ዓ.ም or ዓ/ም , እ.ኤ.አ, ዶ.ር etc. We should consider backslash too for the update I guess!

[quaja-abu]

By the way in the previous sentence collector it was working fine. I don't know why it is not working right now.

[moz-dfeller]

Fixed in #4050