GithubHelp home page GithubHelp logo

Comments (7)

johnbeve avatar johnbeve commented on September 27, 2024 2

This may be a BFO issue. The three properties in question are from RO, not CCO.

BFO ≠ RO.

I think the problem is the contained in super-property assertion:

Agreed:

Screenshot 2023-08-15 at 7 42 54 PM

from commoncoreontologies.

mark-jensen avatar mark-jensen commented on September 27, 2024 2

@jonathanvajda Great catch! Thank you. As both @swartik and @johnbeve point out, the problem wrt reasoning is the odd way RO handles contained_in (CI) and located_in (LI) and part_of (PO). PO is transitive. CI is not.

x CI y is a shortcut for x LI z & z PO y
but
x LI z is a shortcut for x LI q & q PO z
so
x CI y means that x LI q & q PO z & z PO y
and so on ...

The metadata for CI says "containment is location without parthood". Really? How? I really don't like this. Makes me squirm in my seat. Which may explain #693 & #739. RO has just recently obsoleted CI!

CCO is not w/o fault here though. In our documentation we recommend using LI to connect subtypes of bfo:sites, yet our axioms for those subtypes, such as FOAR, use PO.

++1 for @johnbeve for noting that BFO is not RO. With the upcoming adoption of BFO2020 and a core set of non-temporal relations, we will be resolving some of these headaches.

In the short-term, the best fix is probaby to delete all those axioms for the Admin Regions that use PO.

from commoncoreontologies.

swartik avatar swartik commented on September 27, 2024 1

I think the problem is the contained in super-property assertion:

located_in o part_of SubPropertyOf contained_in

The domain of contained_in is a material entity, so the Local Administrative Region individual is inferred to be a material entity.

This may be a BFO issue. The three properties in question are from RO, not CCO.

from commoncoreontologies.

jonathanvajda avatar jonathanvajda commented on September 27, 2024

I think the problem is the contained in super-property assertion:

located_in o part_of SubPropertyOf contained_in

The domain of contained_in is a material entity, so the Local Administrative Region individual is inferred to be a material entity.

This may be a BFO issue. The three properties in question are from RO, not CCO.

Interesting point. Perhaps we should raise it up to the level of RO.

As for CCO, if the part_of axiom is taken out of FOAR (first order admin region), then no contained_in relation is inferred, and that also fixes it. But then again, "Constitutive State" should have the axiom (given its name) and we would face the same issue.

Anyone know when this would have broken? E.g., did CCO 1.3 have (or inherit) this issue all this time?

from commoncoreontologies.

jonathanvajda avatar jonathanvajda commented on September 27, 2024

Hey Mark,

All makes sense. Good tracking down RO's deprecation. Does this mean CCO will deprecate likewise? It would solve without removing axioms.

from commoncoreontologies.

jonathanvajda avatar jonathanvajda commented on September 27, 2024

Following up:

It seems like your proposed solution was to delete the axioms for first-order admin region, but

  • the axiom comes from the definition, and so if it is removed it seems like that is a sufficient condition for deprecating the term
  • the axiom is fine, if ERO deletes the "contains"/"contained in" relation which as you noted was obsoleted in RO

Wouldn't deprecating the problematic RO relations be preferred solution in order to close this ticket?

from commoncoreontologies.

cameronmore avatar cameronmore commented on September 27, 2024

Will be fixing in the bfo2020-core branch

from commoncoreontologies.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.