[Bug]: BottomSheet Multiple Instance are created on multiple taps about apps-android-commons

[shashankiitbhu]

This won't be complex task and it won't be large refactoring. It would just require to pass bundle to the bottomsheet.

I understand that it won't be a difficult task but my point is it's rather unnecessary and adding flags like this before opening the bottom sheet is not really a recommended method.

As I mentioned in a previous comment that you should check out some standard Android apps (built by Google itself following the Best Practices) , there too you can reproduce this issue mentioned. (Google tasks for example)

My suggestion wasn't related to the complexity of tasks but rather maintaining the best practices and code quality.

If we were to act on every possibility like this (let's take slow response time on older devices for example) that would require is to handle 100s of unnecessary cases , you can reproduce this kind of discrepancies on older devices for almost every app available on Play Store.

[shashankiitbhu]

@neeldoshii
Isn't this rare to occur practically, I cannot reproduce this on one of my Physical Devices. (You have to click really fast on a very responsive device I suppose) , also the solution you suggest isn't common (or mostly required for creating bottom sheets) - this would add another layer of complexity to it. what do you think? also, I would suggest trying to test this behavior (bottom sheet) on other standard Android apps (Like Google Tasks for example) because this behavior can also be observed there (and many other apps as according to standard documentation you don't need to handle the case that you mentioned)

[rohit9625]

We can't reproduce this issue as I suspect it happens only on your device because of a recent change you made on a bottom sheet by this PR #5578
Please resolve this behavior in that PR :)
There is no need to create another issue for that.

[ShashwatKedia]

We can't reproduce this issue as I suspect it happens only on your device because of a recent change you made on a bottom sheet by this PR #5578
Please resolve this behavior in that PR :)
There is no need to create another issue for that.

On, the contrary I was able to reproduce this behaviour on the main branch, though it was very difficult to reproduce and occurred once in 5 tries :(

[neeldoshii]

Isn't this rare to occur practically, I cannot reproduce this on one of my Physical Devices. (You have to click really fast on a very responsive device I suppose)

@shashankiitbhu
No, this is common to occur on older device where the memory of the device is very low. When you click on the button and it didn't loaded the bottom-sheet faster than usual the user tends to perform multiple tap on it which leads to creating multiple instance. Considering your point if you consider newer device its rare to occur but thinking from x% of users who are still using >Android 10 version device with less than 2-3GB ram device. Its worth considering wide range of users.

This would add another layer of complexity to it. what do you think?

This won't be complex task and it won't be large refactoring. It would just require to pass bundle to the bottomsheet. if the bottomsheet claas bundle is null --> create instance else --> its instance is already created and won't create multiple sheet.
The refactor would be less than 30 lines of code.

I would still like to have feedback from other reviewers.
Thanks

[neeldoshii]

We can't reproduce this issue as I suspect it happens only on your device because of a recent change you made on a bottom sheet by this PR #5578
Please resolve this behavior in that PR :)
There is no need to create another issue for that.

@rohit9625
Thanks for your reply. The issue was tested on the main branch.
Coming toward PR #5578, this PR only contains refactors (adding one of the textview, add onClickFunction to open it in the browser) thats it no creation of bottom sheet is touched here. Also this PR is not yet merged into main branch. This issue solely relies towards the bottomsheet instance creation.
Correct me if I am wrong.

I have tested the issue on my 2-3 older testing device and did stress testing towards it. In order to reproduce, you need to perform multiple taps (double, thriple tap on the more button). The bottomsheet is created when the button is clicked so if the button is tapped twice thrice so its creates instance on the number of click done.

I hope I cleared your point. Thanks

On, the contrary I was able to reproduce this behaviour on the main branch, though it was very difficult to reproduce and occurred once in 5 tries :(

Yes, This is highly debatable topic I would say lets work on this issue based on the conclusion based on the discussion, complexity and time. This issue won't have high impact though but will work towards the increasing small performance.

[rohit9625]

@neeldoshii
Apologies for the confusion! I misunderstood the problem; I initially thought it might be related to activity creation, possibly caused by certain conditional statements.

However, I haven't pulled from the main branch in a while, so I can't reproduce the issue on my device. Thus, I suspected it might be related to a recent pull request.