Add label "Congratulations, all pictures in this album have been either uploaded or marked as not for upload." about apps-android-commons

[nicolas-raoul]

@Thejas775 Thanks for your enthusiasm, however better work on unassigned bugs (the app has enough bugs for everybody haha) next time.

@starrain1031 Sorry for unusual workflow this time. Maybe review Thejas775's pull request, improve it if possible, then work on a second bug if you want? :-)

[starrain1031]

I would like to try to solve this problem. Would you like to assign it to me?

Are you still working on this issue ?

Yes. However, based on my limited skills, it might take me sometime.

[Thejas775]

I'm really sorry but this was my first contribution to open source as well. This was a good first issue that I thought I could solve.

[neeldoshii]

Can we either display "An vector" like this?

If no image is left to upload or masked as not for upload, we can display svg image & display text like

1. Custom Picker finalised: Every image is now either uploaded or marked.
2. Album perfection achieved: Every photo uploaded or sorted.
   I don't think congratulations is right word as if some person has marked all images not for upload will get text congratulation might be incorrect from UX copywriting pov.

Credits

What do you think about it @nicolas-raoul. I can tackle this while my wikimedia id is banned.

[nicolas-raoul]

@neeldoshii Sorry for the delay! Yes vetor image would be nice, if possible.

"Congratulations": Even marking all pictures as not for upload is good, so I think it is a good opportunity to make people feel good. :-) Maybe something like "Good job! [...]"

Maybe it could even suggest the user to perform peer reviews or go take nearby pictures, with buttons to launch these activities.

[starrain1031]

I would like to try to solve this problem. Would you like to assign it to me?

[Thejas775]

I would like to try to solve this problem. Would you like to assign it to me?

Are you still working on this issue ?

[nicolas-raoul]

@Thejas775 That's understandable :-) You might want to read https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md#developers which has the link to unassigned bugs. I hope you will enjoy fixing other bugs :-)

[Thejas775]

@Thejas775 Thanks for your enthusiasm, however better work on unassigned bugs (the app has enough bugs for everybody haha) next time.

@starrain1031 Sorry for unusual workflow this time. Maybe review Thejas775's pull request, improve it if possible, then work on a second bug if you want? :-)

Will follow the workflow from next time.

[Thejas775]

@Thejas775 That's understandable :-) You might want to read https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md#developers which has the link to unassigned bugs. I hope you will enjoy fixing other bugs :-)

Yeah sure seems intresting.