Comments (3)
PR #25
from angular-bootstrap-lightbox.
I was about to release this change, but now I think there is a good reason to have ui.bootstrap
as the main module containing all the submodules you need. Here is why.
When I use the Create a Build feature and include only Modal, the generated scripts start with the following.
Build without templates:
angular.module("ui.bootstrap", ["ui.bootstrap.modal"]);
angular.module('ui.bootstrap.modal', [])
Build with templates:
angular.module("ui.bootstrap", ["ui.bootstrap.tpls","ui.bootstrap.modal"]);
angular.module("ui.bootstrap.tpls", ["template/modal/backdrop.html","template/modal/window.html"]);
angular.module('ui.bootstrap.modal', [])
- If the
bootstrapLightbox
module depends on bothui.bootstrap.modal
andui.bootstrap.tpls
, it won't work for apps that don't useui.bootstrap.tpls
, when a person creates their own templates. - If the
bootstrapLightbox
module depends only onui.bootstrap.modal
, it won't work for apps that needui.bootstrap.tpls
and don't depend on it orui.bootstrap
explicitly. There would be errors that the templatestemplate/modal/backdrop.html
andtemplate/modal/window.html
can't be found. - If the
bootstrapLightbox
module depends on neither, then it won't work for apps that depend only onbootstrapLightbox
and notui.bootstrap*
. There would be an error that the$modal
provider does not exist.
from angular-bootstrap-lightbox.
I'm importing component per component from UI Bootstrap and lazy-load them when needed, so there's no ui.bootstrap
module and angular-bootstrap-lightbox
crashes. I've solved it by defining a dummy module before loading it:
angular.module('ui.bootstrap', []);
It's a bit awkward but it works. @compact your statements above are correct but it's still a bit weird that you would limit the way of packaging the lib in favor of telling users to include UI Bootstrap (it's in the name of the module, duh).
from angular-bootstrap-lightbox.
Related Issues (20)
- Wrong encoding for closing character ×
- Sass version of the css?
- Error when added in a controller HOT 2
- Loading Progress
- ECONFLICT Error for bower
- Make window same size as image (full size) HOT 1
- Prevent Image from being Removed upon Close
- Failed to load image when image property is not "url" HOT 1
- Using Two Lightbox Templates HOT 1
- templateUrl not recognized by webpack HOT 2
- Angular 4 compatible?
- Possibly unhandled rejection: backdrop click
- if i use jquery version more than 1.8.0 version it was not working could you please guide me
- lightbox not render HOT 1
- Localization support
- support for BootStrap V 4.0
- Use LightBox with two different imageUrl
- Is it supported rotate?
- Multiple Requests on image load HOT 1
- Can't play video when calling openLightboxModal event
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-bootstrap-lightbox.