GithubHelp home page GithubHelp logo

Comments (4)

compact avatar compact commented on July 23, 2024

Please try with v0.3.1.

If the problem remains, what devices/browsers are you using? Do the images not fill up the screen vertically when there are side margins?

The hard-coded numbers are not good practice, though they are directly based on Bootstrap's CSS values. I'll think about whether there's a better way to do it.

from angular-bootstrap-lightbox.

Ryuno-Ki avatar Ryuno-Ki commented on July 23, 2024

@compact You could, at the very least, put those numbers into an object and expose it to the developers to make it more configurable.

from angular-bootstrap-lightbox.

compact avatar compact commented on July 23, 2024

You can edit the calculation methods themselves, as in http://compact.github.io/angular-bootstrap-lightbox/demo2/index.html

from angular-bootstrap-lightbox.

wintermute42 avatar wintermute42 commented on July 23, 2024

In my experience, setting dimensions to max actually works pretty well:

    LightboxProvider.calculateImageDimensionLimits = function (dimensions) {
        return {
            'maxWidth': dimensions.windowWidth,
            'maxHeight': dimensions.windowHeight
        };
    };

    LightboxProvider.calculateModalDimensions = function (dimensions) {
        return {
            'width': dimensions.imageDisplayWidth,
            'height': dimensions.imageDisplayHeight
        };
    };

from angular-bootstrap-lightbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.