Comments (4)
Please try with v0.3.1.
If the problem remains, what devices/browsers are you using? Do the images not fill up the screen vertically when there are side margins?
The hard-coded numbers are not good practice, though they are directly based on Bootstrap's CSS values. I'll think about whether there's a better way to do it.
from angular-bootstrap-lightbox.
@compact You could, at the very least, put those numbers into an object and expose it to the developers to make it more configurable.
from angular-bootstrap-lightbox.
You can edit the calculation methods themselves, as in http://compact.github.io/angular-bootstrap-lightbox/demo2/index.html
from angular-bootstrap-lightbox.
In my experience, setting dimensions to max actually works pretty well:
LightboxProvider.calculateImageDimensionLimits = function (dimensions) {
return {
'maxWidth': dimensions.windowWidth,
'maxHeight': dimensions.windowHeight
};
};
LightboxProvider.calculateModalDimensions = function (dimensions) {
return {
'width': dimensions.imageDisplayWidth,
'height': dimensions.imageDisplayHeight
};
};
from angular-bootstrap-lightbox.
Related Issues (20)
- Wrong encoding for closing character ×
- Sass version of the css?
- Error when added in a controller HOT 2
- Loading Progress
- ECONFLICT Error for bower
- Make window same size as image (full size) HOT 1
- Prevent Image from being Removed upon Close
- Failed to load image when image property is not "url" HOT 1
- Using Two Lightbox Templates HOT 1
- templateUrl not recognized by webpack HOT 2
- Angular 4 compatible?
- Possibly unhandled rejection: backdrop click
- if i use jquery version more than 1.8.0 version it was not working could you please guide me
- lightbox not render HOT 1
- Localization support
- support for BootStrap V 4.0
- Use LightBox with two different imageUrl
- Is it supported rotate?
- Multiple Requests on image load HOT 1
- Can't play video when calling openLightboxModal event
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-bootstrap-lightbox.