Building a tagged llvm version of an already built commit hash skips about clang-builder

[partouf]

For now im gonna copy paste current nightly to 10.0.1

[apmorton]

This should be a non-issue if you just don't pass a revision to the build script when running the tagged build (or change the build name so the revision file doesn't exist if copying the admin daily builds script)

[partouf]

but I passed clang llvm build.sh llvm 10.0.1 or whatever order

[partouf]

it doesn't take into account the version tag when it comes to llvm

[apmorton]

LAST_REVISION="${3}"

if you don't pass a previous revision to build.sh, there is nothing to compare to and it will always build.

The output you show above indicates you copied our admin-daily-build.sh and didn't change the build name to prevent that script from reading the revision file.

See comments in slack.

[partouf]

I don't think you understand. i get I needed to pass 10.0.1, I did. The problem is that the script does everything right up until it determines the logged version to build. Which only takes into account to commit revision, which totally makes sense! Why build the same thing twice! Except that a tag in git doesn't create a new commit hash, you have a commit hash and it may or not be tagged. In this case, the latest commit and the latest tag were one and the same. I could have waited a day or two and I wouldn't have noticed any of this.

[apmorton]

I understand - I'm saying the scripts in this repo do not have any notion of previously built versions.

the arguments to build.sh are:

./build.sh "tag_to_build" "/path/to/output.tar.xz" "last_build_revision"

admin-daily-builds.sh in our infra repo is what handles keeping track of and passing the last_build_revision to this script.
If you don't pass last_build_revision, this script will ALWAYS build.

If you are using the method I showed to build tagged releases where you make a temp copy of admin-daily-builds.sh, you just need to make sure you pass in a unique build name (along with the correct tag to build).

# this will suffer the issue you describe here if the last build has the same commit as the tag given
build_latest clang clang build.sh 10.0.1

# this will always build
build_latest clang clang1001 build.sh 10.0.1

Alternatively, if you manually start the builder and run ce builder exec, just don't pass anything for the third argument of build.sh

ce builder exec -- \
	sudo docker run --rm --name "clang.build" \
	-v/home/ubuntu/.s3cfg:/root/.s3cfg:ro -e 'LOGSPOUT=ignore' \
	"compilerexplorer/clang-builder" \
        bash build.sh "10.0.1" s3://compiler-explorer/opt/

[partouf]

It took me a while to see it, but I get it now. It's not super intuitive, but I'm ok with doing it this way next time. Thanks!